From: "Hennerich, Michael" <Michael.Hennerich@analog.com>
To: Lin Ma <linma@zju.edu.cn>,
"alex.aring@gmail.com" <alex.aring@gmail.com>,
"stefan@datenfreihafen.org" <stefan@datenfreihafen.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"linux-wpan@vger.kernel.org" <linux-wpan@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v0] ieee802154/adf7242: defer destroy_workqueue call
Date: Mon, 8 Aug 2022 07:43:26 +0000 [thread overview]
Message-ID: <SJ0PR03MB6253908F6D8D881062B780428E639@SJ0PR03MB6253.namprd03.prod.outlook.com> (raw)
In-Reply-To: <20220808034224.12642-1-linma@zju.edu.cn>
> -----Original Message-----
> From: Lin Ma <linma@zju.edu.cn>
> Sent: Montag, 8. August 2022 05:42
> To: Hennerich, Michael <Michael.Hennerich@analog.com>;
> alex.aring@gmail.com; stefan@datenfreihafen.org; davem@davemloft.net;
> edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; linux-
> wpan@vger.kernel.org; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Cc: Lin Ma <linma@zju.edu.cn>
> Subject: [PATCH v0] ieee802154/adf7242: defer destroy_workqueue call
>
>
> There is a possible race condition (use-after-free) like below
>
> (FREE) | (USE)
> adf7242_remove | adf7242_channel
> cancel_delayed_work_sync |
> destroy_workqueue (1) | adf7242_cmd_rx
> | mod_delayed_work (2)
> |
>
> The root cause for this race is that the upper layer (ieee802154) is unaware of
> this detaching event and the function adf7242_channel can be called without
> any checks.
>
> To fix this, we can add a flag write at the beginning of adf7242_remove and
> add flag check in adf7242_channel. Or we can just defer the destructive
> operation like other commit 3e0588c291d6 ("hamradio: defer
> ax25 kfree after unregister_netdev") which let the
> ieee802154_unregister_hw() to handle the synchronization. This patch takes
> the second option.
>
> Fixes: 58e9683d1475 ("net: ieee802154: adf7242: Fix OCL calibration
> runs")
> Signed-off-by: Lin Ma <linma@zju.edu.cn>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
> ---
> drivers/net/ieee802154/adf7242.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ieee802154/adf7242.c
> b/drivers/net/ieee802154/adf7242.c
> index 6afdf1622944..efcc45aef508 100644
> --- a/drivers/net/ieee802154/adf7242.c
> +++ b/drivers/net/ieee802154/adf7242.c
> @@ -1310,10 +1310,11 @@ static void adf7242_remove(struct spi_device
> *spi)
>
> debugfs_remove_recursive(lp->debugfs_root);
>
> + ieee802154_unregister_hw(lp->hw);
> +
> cancel_delayed_work_sync(&lp->work);
> destroy_workqueue(lp->wqueue);
> -
> - ieee802154_unregister_hw(lp->hw);
> +
> mutex_destroy(&lp->bmux);
> ieee802154_free_hw(lp->hw);
> }
> --
> 2.36.1
next prev parent reply other threads:[~2022-08-08 7:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-08 3:42 [PATCH v0] ieee802154/adf7242: defer destroy_workqueue call Lin Ma
2022-08-08 7:43 ` Hennerich, Michael [this message]
2022-08-23 8:03 ` Stefan Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR03MB6253908F6D8D881062B780428E639@SJ0PR03MB6253.namprd03.prod.outlook.com \
--to=michael.hennerich@analog.com \
--cc=alex.aring@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linma@zju.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stefan@datenfreihafen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).