From: Dave Chinner <david@fromorbit.com>
To: Carlos Maiolino <cmaiolino@redhat.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: Forbid FIEMAP on RT devices
Date: Wed, 20 Nov 2019 07:25:11 +1100 [thread overview]
Message-ID: <20191119202511.GY4614@dread.disaster.area> (raw)
In-Reply-To: <20191119154453.312400-1-cmaiolino@redhat.com>
On Tue, Nov 19, 2019 at 04:44:53PM +0100, Carlos Maiolino wrote:
> By now, FIEMAP users have no way to identify which device contains the
> mapping being reported by the ioctl,
This is an incorrect assertion.
Users can call FS_IOC_FSGETXATTR and look at the FS_XFLAG_REALTIME
flag returned to determine what device the XFS data mapping points
at.
> so, let's forbid FIEMAP on RT
> devices/files until FIEMAP can properly report the device containing the
> returned mappings.
Also, fiemap on the attribute fork should work regardless of where
the data for the file is located.
So that's two reasons we shouldn't do this :P
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2019-11-19 20:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 15:44 [PATCH] xfs: Forbid FIEMAP on RT devices Carlos Maiolino
2019-11-19 15:48 ` Carlos Maiolino
2019-11-19 16:10 ` Eric Sandeen
2019-11-19 16:50 ` Carlos Maiolino
2019-11-19 20:25 ` Dave Chinner [this message]
2019-11-20 8:17 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191119202511.GY4614@dread.disaster.area \
--to=david@fromorbit.com \
--cc=cmaiolino@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).