From: Dave Chinner <david@fromorbit.com>
To: Pavel Reichl <preichl@redhat.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH v4 4/4] xfs: Replace mrlock_t by rw_semaphore
Date: Wed, 12 Feb 2020 11:49:02 +1100 [thread overview]
Message-ID: <20200212004902.GR10776@dread.disaster.area> (raw)
In-Reply-To: <20200211221018.709125-4-preichl@redhat.com>
On Tue, Feb 11, 2020 at 11:10:18PM +0100, Pavel Reichl wrote:
> Remove mrlock_t as it does not provide any extra value over rw_semaphores.
> Make i_lock and i_mmaplock native rw_semaphores and replace mr*() functions
> with native rwsem calls.
wrapping at 68-72 columns.
> Signed-off-by: Pavel Reichl <preichl@redhat.com>
Subject "xfs: replace mrlock_t with rw_semaphores" or "xfs: remove
mrlock_t wrappers"
> diff --git a/fs/xfs/xfs_inode.h b/fs/xfs/xfs_inode.h
> index 3d7ce355407d..8b30f82b9dc0 100644
> --- a/fs/xfs/xfs_inode.h
> +++ b/fs/xfs/xfs_inode.h
> @@ -9,6 +9,8 @@
> #include "xfs_inode_buf.h"
> #include "xfs_inode_fork.h"
>
> +#include <linux/rwsem.h>
> +
Linux specific includes belong in fs/xfs/xfs_linux.h, not random XFS
header files.
Hmmm....
> diff --git a/fs/xfs/xfs_linux.h b/fs/xfs/xfs_linux.h
> index 8738bb03f253..921a3eb093ed 100644
> --- a/fs/xfs/xfs_linux.h
> +++ b/fs/xfs/xfs_linux.h
> @@ -22,7 +22,6 @@ typedef __u32 xfs_nlink_t;
> #include "xfs_types.h"
>
> #include "kmem.h"
> -#include "mrlock.h"
.... that's where rwsem.h currently gets included (via mrlock.h)
into the XFS codebase.
IOWs, the "#include <linux/rwsem.h>" should replace this include,
not get moved to xfs_inode.h.
Otherwise the patch looks fine.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2020-02-12 0:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 22:10 [PATCH v4 1/4] xfs: Refactor xfs_isilocked() Pavel Reichl
2020-02-11 22:10 ` [PATCH v4 2/4] xfs: Fix WS in xfs_isilocked() calls Pavel Reichl
2020-02-12 0:35 ` Dave Chinner
2020-02-11 22:10 ` [PATCH v4 3/4] xfs: Fix bug when checking diff. locks Pavel Reichl
2020-02-12 0:38 ` Dave Chinner
2020-02-11 22:10 ` [PATCH v4 4/4] xfs: Replace mrlock_t by rw_semaphore Pavel Reichl
2020-02-12 0:49 ` Dave Chinner [this message]
2020-02-11 22:27 ` [PATCH v4 1/4] xfs: Refactor xfs_isilocked() Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200212004902.GR10776@dread.disaster.area \
--to=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
--cc=preichl@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).