From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AE49C83012 for ; Tue, 1 Dec 2020 10:04:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A4100206C0 for ; Tue, 1 Dec 2020 10:04:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="bdj4KVUi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729030AbgLAKED (ORCPT ); Tue, 1 Dec 2020 05:04:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725912AbgLAKED (ORCPT ); Tue, 1 Dec 2020 05:04:03 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 503D3C0613D3 for ; Tue, 1 Dec 2020 02:03:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=pFnqZmC6osdjRNkoYXd/Bc/q2vkpZX6g1nmR7lEDszs=; b=bdj4KVUi7a9K8nezuu98qkcOzx XIRWhSFkwFf7flFPpZhXjwxA9wk5isV/0ZHkyNA0FdRZ787WUFyChpl9KOWiAVMAPXEnxCTozmA5p 1URxmbpWeCpU064Q8APUDkutyptlkaYFyxdozm8LCJPi8wRPPtqlZSYhctQ/+p3m/A+tvPCdJgO11 +eTDAtbQ/moIb9DOI1IRhoDwyLxPci5TBPaaNgWtEFYn1YUp6hH4kErX2OcCXWzEM/1cEcCRWiA7U omWOxuosixgsvTsShMWW/LXa5/5U4mpVNjBVUs8V7L9pLt9SlaxvGg9/QdqtFJiqfrjJu2jid2QT8 Y25Ce3XQ==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kk2VG-0002rq-2J; Tue, 01 Dec 2020 10:03:22 +0000 Date: Tue, 1 Dec 2020 10:03:22 +0000 From: Christoph Hellwig To: "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org Subject: Re: [PATCH 02/10] xfs: improve the code that checks recovered bmap intent items Message-ID: <20201201100322.GC10262@infradead.org> References: <160679385987.447963.9630288535682256882.stgit@magnolia> <160679387231.447963.15156459924591469631.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <160679387231.447963.15156459924591469631.stgit@magnolia> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Mon, Nov 30, 2020 at 07:37:52PM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong > > The code that validates recovered bmap intent items is kind of a mess -- > it doesn't use the standard xfs type validators, and it doesn't check > for things that it should. Fix the validator function to use the > standard validation helpers and look for more types of obvious errors. > > Signed-off-by: Darrick J. Wong > --- Looks good, Reviewed-by: Christoph Hellwig