From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 04/10] xfs: improve the code that checks recovered rmap intent items
Date: Tue, 1 Dec 2020 10:05:35 +0000 [thread overview]
Message-ID: <20201201100535.GE10262@infradead.org> (raw)
In-Reply-To: <160679388445.447963.9471776418395898485.stgit@magnolia>
On Mon, Nov 30, 2020 at 07:38:04PM -0800, Darrick J. Wong wrote:
> + if (!xfs_verify_ino(mp, rmap->me_owner) &&
> + !XFS_RMAP_NON_INODE_OWNER(rmap->me_owner))
> + return false;
Wouldn't it make sense to reverse the order of the checks here?
> + end = rmap->me_startblock + rmap->me_len - 1;
> + if (!xfs_verify_fsbno(mp, rmap->me_startblock) ||
> + !xfs_verify_fsbno(mp, end))
> return false;
Nit: why not simply:
if (!xfs_verify_fsbno(mp, rmap->me_startblock))
return false;
if (!xfs_verify_fsbno(mp, rmap->me_startblock + rmap->me_len - 1))
return false;
?
next prev parent reply other threads:[~2020-12-01 10:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 3:37 [PATCH 00/10] xfs: strengthen log intent validation Darrick J. Wong
2020-12-01 3:37 ` [PATCH 01/10] xfs: hoist recovered bmap intent checks out of xfs_bui_item_recover Darrick J. Wong
2020-12-01 10:02 ` Christoph Hellwig
2020-12-01 3:37 ` [PATCH 02/10] xfs: improve the code that checks recovered bmap intent items Darrick J. Wong
2020-12-01 10:03 ` Christoph Hellwig
2020-12-01 3:37 ` [PATCH 03/10] xfs: hoist recovered rmap intent checks out of xfs_rui_item_recover Darrick J. Wong
2020-12-01 10:03 ` Christoph Hellwig
2020-12-01 3:38 ` [PATCH 04/10] xfs: improve the code that checks recovered rmap intent items Darrick J. Wong
2020-12-01 10:05 ` Christoph Hellwig [this message]
2020-12-01 16:33 ` Darrick J. Wong
2020-12-01 16:53 ` [PATCH v2 " Darrick J. Wong
2020-12-01 3:38 ` [PATCH 05/10] xfs: hoist recovered refcount intent checks out of xfs_cui_item_recover Darrick J. Wong
2020-12-01 10:05 ` Christoph Hellwig
2020-12-01 3:38 ` [PATCH 06/10] xfs: improve the code that checks recovered refcount intent items Darrick J. Wong
2020-12-01 10:06 ` Christoph Hellwig
2020-12-01 3:38 ` [PATCH 07/10] xfs: hoist recovered extent-free intent checks out of xfs_efi_item_recover Darrick J. Wong
2020-12-01 10:06 ` Christoph Hellwig
2020-12-01 3:38 ` [PATCH 08/10] xfs: improve the code that checks recovered extent-free intent items Darrick J. Wong
2020-12-01 10:07 ` Christoph Hellwig
2020-12-01 3:38 ` [PATCH 09/10] xfs: validate feature support when recovering rmap/refcount/bmap intents Darrick J. Wong
2020-12-01 10:07 ` Christoph Hellwig
2020-12-01 3:38 ` [PATCH 10/10] xfs: trace log intent item recovery failures Darrick J. Wong
2020-12-01 10:07 ` Christoph Hellwig
2020-12-04 1:11 [PATCH v2 00/10] xfs: strengthen log intent validation Darrick J. Wong
2020-12-04 1:12 ` [PATCH 04/10] xfs: improve the code that checks recovered rmap intent items Darrick J. Wong
2020-12-04 13:59 ` Brian Foster
2020-12-06 23:09 [PATCH v3 00/10] xfs: strengthen log intent validation Darrick J. Wong
2020-12-06 23:10 ` [PATCH 04/10] xfs: improve the code that checks recovered rmap intent items Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201201100535.GE10262@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).