From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 268D3C83016 for ; Tue, 1 Dec 2020 10:06:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 81CE12084C for ; Tue, 1 Dec 2020 10:06:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="TO65Bk9N" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729676AbgLAKGd (ORCPT ); Tue, 1 Dec 2020 05:06:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726589AbgLAKGc (ORCPT ); Tue, 1 Dec 2020 05:06:32 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD94DC0613CF for ; Tue, 1 Dec 2020 02:05:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=f3nqW1vb4555YHnF3HpSsqhG4ryY/ZBPfWVN69k/Q6c=; b=TO65Bk9NvVJIJKoj5hsJzlwYHi Rvuc/S3uSwQAxcFR2NEkm7V46Legb65nnNUcDEbV7atdo4fo4wi9EoS2gQqwXq7UDDDHl7lCJRqMK KxzNpFZFqH13ttdXuYwKsQ4TmYl6J57LROXTw6RzKuwMIENOxU5HveVXkjRaKN7LhxzSf6kmPCjAf 2xGqF2FLgnk7nV+vrYqytvH0GH9HNkrrLYFalzUaRowWxeWIR/4blLIwGW0T0tMBOozImg9ZTsZ+A lryLZDXvR6HxOjogYeN5vz/bpgxfcdCjzMJQNA+r1R7+EchoTc1Ze4/ioOvChx6YDbOD1f0PyTJcf cO/f4Ncw==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kk2Xf-0003AU-Cs; Tue, 01 Dec 2020 10:05:51 +0000 Date: Tue, 1 Dec 2020 10:05:51 +0000 From: Christoph Hellwig To: "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org Subject: Re: [PATCH 05/10] xfs: hoist recovered refcount intent checks out of xfs_cui_item_recover Message-ID: <20201201100551.GF10262@infradead.org> References: <160679385987.447963.9630288535682256882.stgit@magnolia> <160679389048.447963.5353838196502010594.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <160679389048.447963.5353838196502010594.stgit@magnolia> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Mon, Nov 30, 2020 at 07:38:10PM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong > > When we recover a refcount intent from the log, we need to validate its > contents before we try to replay them. Hoist the checking code into a > separate function in preparation to refactor this code to use validation > helpers. > > Signed-off-by: Darrick J. Wong Looks good, Reviewed-by: Christoph Hellwig