From: Brian Foster <bfoster@redhat.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 10/10] xfs: trace log intent item recovery failures
Date: Fri, 4 Dec 2020 09:00:52 -0500 [thread overview]
Message-ID: <20201204140052.GL1404170@bfoster> (raw)
In-Reply-To: <160704435695.734470.320027217185016602.stgit@magnolia>
On Thu, Dec 03, 2020 at 05:12:37PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Add a trace point so that we can capture when a recovered log intent
> item fails to recover.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> ---
> fs/xfs/xfs_log_recover.c | 5 ++++-
> fs/xfs/xfs_trace.h | 19 +++++++++++++++++++
> 2 files changed, 23 insertions(+), 1 deletion(-)
>
>
> diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c
> index 87886b7f77da..ed92c72976c9 100644
> --- a/fs/xfs/xfs_log_recover.c
> +++ b/fs/xfs/xfs_log_recover.c
> @@ -2559,8 +2559,11 @@ xlog_recover_process_intents(
> spin_unlock(&ailp->ail_lock);
> error = lip->li_ops->iop_recover(lip, &capture_list);
> spin_lock(&ailp->ail_lock);
> - if (error)
> + if (error) {
> + trace_xfs_error_return(log->l_mp, error,
> + lip->li_ops->iop_recover);
> break;
> + }
> }
>
> xfs_trans_ail_cursor_done(&cur);
> diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h
> index 86951652d3ed..99383b1acd49 100644
> --- a/fs/xfs/xfs_trace.h
> +++ b/fs/xfs/xfs_trace.h
> @@ -103,6 +103,25 @@ DEFINE_ATTR_LIST_EVENT(xfs_attr_list_notfound);
> DEFINE_ATTR_LIST_EVENT(xfs_attr_leaf_list);
> DEFINE_ATTR_LIST_EVENT(xfs_attr_node_list);
>
> +TRACE_EVENT(xfs_error_return,
xfs_error_return seems rather vague of a name given the current use.
> + TP_PROTO(struct xfs_mount *mp, int error, void *caller_ip),
> + TP_ARGS(mp, error, caller_ip),
> + TP_STRUCT__entry(
> + __field(dev_t, dev)
> + __field(int, error)
> + __field(void *, caller_ip)
> + ),
> + TP_fast_assign(
> + __entry->dev = mp->m_super->s_dev;
> + __entry->error = error;
> + __entry->caller_ip = caller_ip;
> + ),
> + TP_printk("dev %d:%d error %d caller %pS",
> + MAJOR(__entry->dev), MINOR(__entry->dev),
> + __entry->error, __entry->caller_ip)
> +
Extra whitespace. Also, using the text "caller" here is a bit misleading
IMO. I'd suggest just calling it "function" or some such, but not that
big of a deal.
Brian
> +);
> +
> DECLARE_EVENT_CLASS(xfs_perag_class,
> TP_PROTO(struct xfs_mount *mp, xfs_agnumber_t agno, int refcount,
> unsigned long caller_ip),
>
next prev parent reply other threads:[~2020-12-04 14:02 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 1:11 [PATCH v2 00/10] xfs: strengthen log intent validation Darrick J. Wong
2020-12-04 1:11 ` [PATCH 01/10] xfs: hoist recovered bmap intent checks out of xfs_bui_item_recover Darrick J. Wong
2020-12-04 13:55 ` Brian Foster
2020-12-04 1:11 ` [PATCH 02/10] xfs: improve the code that checks recovered bmap intent items Darrick J. Wong
2020-12-04 13:56 ` Brian Foster
2020-12-04 19:54 ` Darrick J. Wong
2020-12-04 1:11 ` [PATCH 03/10] xfs: hoist recovered rmap intent checks out of xfs_rui_item_recover Darrick J. Wong
2020-12-04 13:59 ` Brian Foster
2020-12-04 1:12 ` [PATCH 04/10] xfs: improve the code that checks recovered rmap intent items Darrick J. Wong
2020-12-04 13:59 ` Brian Foster
2020-12-04 1:12 ` [PATCH 05/10] xfs: hoist recovered refcount intent checks out of xfs_cui_item_recover Darrick J. Wong
2020-12-04 14:00 ` Brian Foster
2020-12-04 1:12 ` [PATCH 06/10] xfs: improve the code that checks recovered refcount intent items Darrick J. Wong
2020-12-04 14:00 ` Brian Foster
2020-12-04 1:12 ` [PATCH 07/10] xfs: hoist recovered extent-free intent checks out of xfs_efi_item_recover Darrick J. Wong
2020-12-04 14:00 ` Brian Foster
2020-12-04 1:12 ` [PATCH 08/10] xfs: improve the code that checks recovered extent-free intent items Darrick J. Wong
2020-12-04 14:00 ` Brian Foster
2020-12-04 1:12 ` [PATCH 09/10] xfs: validate feature support when recovering rmap/refcount/bmap intents Darrick J. Wong
2020-12-04 14:00 ` Brian Foster
2020-12-06 23:08 ` Darrick J. Wong
2020-12-07 14:02 ` Brian Foster
2020-12-07 16:50 ` Darrick J. Wong
2020-12-04 1:12 ` [PATCH 10/10] xfs: trace log intent item recovery failures Darrick J. Wong
2020-12-04 14:00 ` Brian Foster [this message]
2020-12-04 19:57 ` Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2020-12-06 23:09 [PATCH v3 00/10] xfs: strengthen log intent validation Darrick J. Wong
2020-12-06 23:10 ` [PATCH 10/10] xfs: trace log intent item recovery failures Darrick J. Wong
2020-12-07 17:28 ` Brian Foster
2020-12-07 18:27 ` Darrick J. Wong
2020-12-01 3:37 [PATCH 00/10] xfs: strengthen log intent validation Darrick J. Wong
2020-12-01 3:38 ` [PATCH 10/10] xfs: trace log intent item recovery failures Darrick J. Wong
2020-12-01 10:07 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201204140052.GL1404170@bfoster \
--to=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).