From: Brian Foster <bfoster@redhat.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: sandeen@sandeen.net, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 3/2] xfs_repair: fix unmount error message to have a newline
Date: Wed, 20 Jan 2021 12:38:39 -0500 [thread overview]
Message-ID: <20210120173839.GB1722880@bfoster> (raw)
In-Reply-To: <20210120043157.GY3134581@magnolia>
On Tue, Jan 19, 2021 at 08:31:57PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Add a newline so that this is consistent with the other error messages.
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
> repair/xfs_repair.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/repair/xfs_repair.c b/repair/xfs_repair.c
> index 724661d8..9409f0d8 100644
> --- a/repair/xfs_repair.c
> +++ b/repair/xfs_repair.c
> @@ -1136,7 +1136,7 @@ _("Note - stripe unit (%d) and width (%d) were copied from a backup superblock.\
> error = -libxfs_umount(mp);
> if (error)
> do_error(
> - _("File system metadata writeout failed, err=%d. Re-run xfs_repair."),
> + _("File system metadata writeout failed, err=%d. Re-run xfs_repair.\n"),
> error);
>
> libxfs_destroy(&x);
>
prev parent reply other threads:[~2021-01-20 18:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-16 1:24 [PATCHSET v2 0/2] xfs: add the ability to flag a fs for repair Darrick J. Wong
2021-01-16 1:24 ` [PATCH 1/2] xfs_db: support the needsrepair feature flag in the version command Darrick J. Wong
2021-01-19 14:37 ` Brian Foster
2021-02-02 21:09 ` Darrick J. Wong
2021-02-03 13:07 ` Brian Foster
2021-02-03 18:30 ` Darrick J. Wong
2021-02-03 19:09 ` Brian Foster
2021-01-16 1:24 ` [PATCH 2/2] xfs_repair: clear the needsrepair flag Darrick J. Wong
2021-01-19 14:37 ` Brian Foster
2021-01-19 18:15 ` Darrick J. Wong
2021-01-19 19:44 ` Brian Foster
2021-01-19 20:31 ` Darrick J. Wong
2021-01-19 23:49 ` Darrick J. Wong
2021-01-20 4:31 ` [PATCH v2.1 " Darrick J. Wong
2021-01-20 17:38 ` Brian Foster
2021-02-02 22:22 ` Darrick J. Wong
2021-01-20 4:31 ` [PATCH 3/2] xfs_repair: fix unmount error message to have a newline Darrick J. Wong
2021-01-20 17:38 ` Brian Foster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210120173839.GB1722880@bfoster \
--to=bfoster@redhat.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).