From: Christoph Hellwig <hch@lst.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Jens Axboe <axboe@kernel.dk>, Tejun Heo <tj@kernel.org>,
linux-block@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 12/13] xfs: convert xfs_errortag attrs to use ->seq_show
Date: Mon, 13 Sep 2021 07:41:20 +0200 [thread overview]
Message-ID: <20210913054121.616001-13-hch@lst.de> (raw)
In-Reply-To: <20210913054121.616001-1-hch@lst.de>
Trivial conversion to the seq_file based sysfs attributes.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
fs/xfs/xfs_error.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/fs/xfs/xfs_error.c b/fs/xfs/xfs_error.c
index 81c445e9489bd..143a1e0b12ffe 100644
--- a/fs/xfs/xfs_error.c
+++ b/fs/xfs/xfs_error.c
@@ -104,22 +104,22 @@ xfs_errortag_attr_store(
return count;
}
-STATIC ssize_t
-xfs_errortag_attr_show(
+STATIC int
+xfs_errortag_attr_seq_show(
struct kobject *kobject,
struct attribute *attr,
- char *buf)
+ struct seq_file *sf)
{
struct xfs_mount *mp = to_mp(kobject);
struct xfs_errortag_attr *xfs_attr = to_attr(attr);
- return snprintf(buf, PAGE_SIZE, "%u\n",
- xfs_errortag_get(mp, xfs_attr->tag));
+ seq_printf(sf, "%u\n", xfs_errortag_get(mp, xfs_attr->tag));
+ return 0;
}
static const struct sysfs_ops xfs_errortag_sysfs_ops = {
- .show = xfs_errortag_attr_show,
- .store = xfs_errortag_attr_store,
+ .seq_show = xfs_errortag_attr_seq_show,
+ .store = xfs_errortag_attr_store,
};
#define XFS_ERRORTAG_ATTR_RW(_name, _tag) \
--
2.30.2
next prev parent reply other threads:[~2021-09-13 5:58 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 5:41 start switching sysfs attributes to expose the seq_file Christoph Hellwig
2021-09-13 5:41 ` [PATCH 01/13] seq_file: mark seq_get_buf as deprecated Christoph Hellwig
2021-09-13 13:19 ` Christian Brauner
2021-09-13 16:22 ` Daniel Wagner
2021-09-13 16:29 ` Tejun Heo
2021-09-13 5:41 ` [PATCH 02/13] kernfs: remove kernfs_create_file and kernfs_create_file_ns Christoph Hellwig
2021-09-13 13:20 ` Christian Brauner
2021-09-13 5:41 ` [PATCH 03/13] kernfs: remove the unused lockdep_key field in struct kernfs_ops Christoph Hellwig
2021-09-13 13:21 ` Christian Brauner
2021-09-13 16:30 ` Tejun Heo
2021-09-13 5:41 ` [PATCH 04/13] sysfs: split out binary attribute handling from sysfs_add_file_mode_ns Christoph Hellwig
2021-09-13 13:26 ` Christian Brauner
2021-09-13 5:41 ` [PATCH 05/13] sysfs: refactor sysfs_add_file_mode_ns Christoph Hellwig
2021-09-13 13:27 ` Christian Brauner
2021-09-13 5:41 ` [PATCH 06/13] sysfs: simplify sysfs_kf_seq_show Christoph Hellwig
2021-09-13 5:41 ` [PATCH 07/13] sysfs: add ->seq_show support to sysfs_ops Christoph Hellwig
2021-09-13 13:30 ` Christian Brauner
2021-09-13 5:41 ` [PATCH 08/13] block: convert the blk_mq_hw_ctx attrs to use ->seq_show Christoph Hellwig
2021-09-13 5:41 ` [PATCH 09/13] block: convert the blk_integrity " Christoph Hellwig
2021-09-13 5:41 ` [PATCH 10/13] block: convert the request_queue " Christoph Hellwig
2021-09-13 5:41 ` [PATCH 11/13] block: convert the elevator_queue " Christoph Hellwig
2021-09-13 5:41 ` Christoph Hellwig [this message]
2021-09-13 5:41 ` [PATCH 13/13] xfs: convert xfs_sysfs " Christoph Hellwig
2021-09-13 6:27 ` Greg Kroah-Hartman
2021-09-14 1:20 ` Dave Chinner
2021-09-14 5:12 ` Greg Kroah-Hartman
2021-09-14 10:56 ` Dave Chinner
2021-09-14 7:30 ` Christoph Hellwig
2021-09-14 15:28 ` Greg Kroah-Hartman
2021-09-14 15:30 ` Christoph Hellwig
2021-09-14 15:41 ` Greg Kroah-Hartman
2021-09-15 7:04 ` Christoph Hellwig
2021-09-15 7:07 ` Greg Kroah-Hartman
2021-09-13 16:39 ` start switching sysfs attributes to expose the seq_file Bart Van Assche
2021-09-13 16:46 ` Greg Kroah-Hartman
2021-09-14 2:53 ` Bart Van Assche
2021-09-13 16:46 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210913054121.616001-13-hch@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=tj@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).