From: Bob Peterson <rpeterso@redhat.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
Naohiro Aota <naohiro.aota@wdc.com>,
linux-xfs@vger.kernel.org, Damien Le Moal <damien.lemoal@wdc.com>,
linux-ext4@vger.kernel.org, Goldwyn Rodrigues <rgoldwyn@suse.de>,
Dave Chinner <david@fromorbit.com>,
Matthew Wilcox <willy@infradead.org>,
cluster-devel@redhat.com, Goldwyn Rodrigues <rgoldwyn@suse.com>,
linux-fsdevel@vger.kernel.org,
Johannes Thumshirn <jth@kernel.org>,
linux-btrfs@vger.kernel.org
Subject: Re: [Cluster-devel] [PATCH 3/3] iomap: fall back to buffered writes for invalidation failures
Date: Wed, 22 Jul 2020 08:19:58 -0400 (EDT) [thread overview]
Message-ID: <595939815.7378944.1595420398243.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20200721203749.GF3151642@magnolia>
----- Original Message -----
> On Tue, Jul 21, 2020 at 08:31:57PM +0200, Christoph Hellwig wrote:
> > Failing to invalid the page cache means data in incoherent, which is
> > a very bad state for the system. Always fall back to buffered I/O
> > through the page cache if we can't invalidate mappings.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > Acked-by: Dave Chinner <dchinner@redhat.com>
> > Reviewed-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
>
> For the iomap and xfs parts,
> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
>
> But I'd still like acks from Ted, Andreas, and Damien for ext4, gfs2,
> and zonefs, respectively.
>
> (Particularly if anyone was harboring ideas about trying to get this in
> before 5.10, though I've not yet heard anyone say that explicitly...)
>
> --D
>
> > ---
> > fs/ext4/file.c | 2 ++
> > fs/gfs2/file.c | 3 ++-
> > fs/iomap/direct-io.c | 16 +++++++++++-----
> > fs/iomap/trace.h | 1 +
> > fs/xfs/xfs_file.c | 4 ++--
> > fs/zonefs/super.c | 7 +++++--
> > 6 files changed, 23 insertions(+), 10 deletions(-)
Hi,
I think Andreas is on holiday this week, but the gfs2 portion looks good to me:
For the gfs2 portion:
Acked-by: Bob Peterson <rpeterso@redhat.com>
Regards,
Bob Peterson
next prev parent reply other threads:[~2020-07-22 12:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 18:31 iomap write invalidation v2 Christoph Hellwig
2020-07-21 18:31 ` [PATCH 1/3] xfs: use ENOTBLK for direct I/O to buffered I/O fallback Christoph Hellwig
2020-07-21 20:35 ` Darrick J. Wong
2020-07-21 18:31 ` [PATCH 2/3] iomap: Only invalidate page cache pages on direct IO writes Christoph Hellwig
2020-07-21 18:31 ` [PATCH 3/3] iomap: fall back to buffered writes for invalidation failures Christoph Hellwig
2020-07-21 20:37 ` Darrick J. Wong
2020-07-22 6:18 ` Christoph Hellwig
2020-07-22 16:15 ` Darrick J. Wong
2020-07-22 12:19 ` Bob Peterson [this message]
2020-07-21 23:01 ` Damien Le Moal
2020-07-22 23:13 ` Darrick J. Wong
2020-07-30 4:00 ` tytso
2020-07-31 7:01 ` Ritesh Harjani
2020-07-31 14:03 ` [Cluster-devel] " Andreas Gruenbacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=595939815.7378944.1595420398243.JavaMail.zimbra@redhat.com \
--to=rpeterso@redhat.com \
--cc=cluster-devel@redhat.com \
--cc=damien.lemoal@wdc.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=jth@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=naohiro.aota@wdc.com \
--cc=rgoldwyn@suse.com \
--cc=rgoldwyn@suse.de \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).