From: Allison Collins <allison.henderson@oracle.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>, sandeen@sandeen.net
Cc: linux-xfs@vger.kernel.org, Eric Sandeen <sandeen@redhat.com>
Subject: Re: [PATCH 2/4] libfrog: remove libxfs.h dependencies in fsgeom.c and linux.c
Date: Tue, 4 Feb 2020 22:28:53 -0700 [thread overview]
Message-ID: <a6b6bb58-e5c2-eab4-d952-d4b02126fd69@oracle.com> (raw)
In-Reply-To: <158086358002.2079557.9233731246621270812.stgit@magnolia>
On 2/4/20 5:46 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> libfrog isn't supposed to depend on libxfs, so don't include the header
> file in the libfrog source code.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Looks ok
Reviewed-by: Allison Collins <allison.henderson@oracle.com>
> ---
> libfrog/fsgeom.c | 4 +++-
> libfrog/linux.c | 4 ++--
> 2 files changed, 5 insertions(+), 3 deletions(-)
>
>
> diff --git a/libfrog/fsgeom.c b/libfrog/fsgeom.c
> index 19a4911f..bd93924e 100644
> --- a/libfrog/fsgeom.c
> +++ b/libfrog/fsgeom.c
> @@ -2,7 +2,9 @@
> /*
> * Copyright (c) 2000-2005 Silicon Graphics, Inc. All Rights Reserved.
> */
> -#include "libxfs.h"
> +#include "platform_defs.h"
> +#include "xfs.h"
> +#include "bitops.h"
> #include "fsgeom.h"
> #include "util.h"
>
> diff --git a/libfrog/linux.c b/libfrog/linux.c
> index 79bd79eb..41a168b4 100644
> --- a/libfrog/linux.c
> +++ b/libfrog/linux.c
> @@ -9,8 +9,8 @@
> #include <sys/ioctl.h>
> #include <sys/sysinfo.h>
>
> -#include "libxfs_priv.h"
> -#include "xfs_fs.h"
> +#include "platform_defs.h"
> +#include "xfs.h"
> #include "init.h"
>
> extern char *progname;
>
next prev parent reply other threads:[~2020-02-05 5:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 0:46 [PATCH 0/4] xfsprogs: random fixes Darrick J. Wong
2020-02-05 0:46 ` [PATCH 1/4] libxfs: re-sort libxfs_api_defs.h defines Darrick J. Wong
2020-02-05 2:11 ` Chaitanya Kulkarni
2020-02-05 5:28 ` Allison Collins
2020-02-17 13:45 ` Christoph Hellwig
2020-02-05 0:46 ` [PATCH 2/4] libfrog: remove libxfs.h dependencies in fsgeom.c and linux.c Darrick J. Wong
2020-02-05 5:28 ` Allison Collins [this message]
2020-02-17 13:46 ` Christoph Hellwig
2020-02-05 0:46 ` [PATCH 3/4] xfs_repair: refactor attr root block pointer check Darrick J. Wong
2020-02-05 5:28 ` Allison Collins
2020-02-13 23:14 ` Eric Sandeen
2020-02-14 4:24 ` Darrick J. Wong
2020-02-17 13:47 ` Christoph Hellwig
2020-02-05 0:46 ` [PATCH 4/4] xfs_repair: don't corrupt a attr fork da3 node when clearing forw/back Darrick J. Wong
2020-02-05 5:29 ` Allison Collins
2020-02-05 5:59 ` Darrick J. Wong
2020-02-17 13:48 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6b6bb58-e5c2-eab4-d952-d4b02126fd69@oracle.com \
--to=allison.henderson@oracle.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).