From: Pavel Reichl <preichl@redhat.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/8] xfsprogs: Rename platform.h -> common.h
Date: Tue, 3 Aug 2021 18:15:12 +0200 [thread overview]
Message-ID: <ce90e2cc-5098-9e9a-c083-16bb73eddd0b@redhat.com> (raw)
In-Reply-To: <20210802223358.GK3601466@magnolia>
On 8/3/21 12:33 AM, Darrick J. Wong wrote:
> On Mon, Aug 02, 2021 at 11:50:18PM +0200, Pavel Reichl wrote:
>> No other platform then linux is supported so rename to something more
>> common.
>> ---
>> copy/xfs_copy.c | 2 +-
>> libfrog/{platform.h => common.h} | 0
> This is confusing, we already have a scrub/common.h. Renaming files
> breaks git blame; why change them?
>
I wanted to rename the file because it contains functions that were
supposed to be multi-platform (at least that's my understanding) but it
never became the case. So since we are trying to get rid of the obsolete
'platform_' prefix I thought that more proper name for the file should
be chosen. However, I respect the git blame consideration and I'm fine
with keeping the name.
next prev parent reply other threads:[~2021-08-03 16:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-02 21:50 [PATCH 0/8] xfsprogs: Drop the 'platform_' prefix Pavel Reichl
2021-08-02 21:50 ` [PATCH 1/8] xfsprogs: Rename platform_defs.h.in -> defs.h.in Pavel Reichl
2021-08-02 21:50 ` [PATCH 2/8] xfsprogs: Rename platform.h -> common.h Pavel Reichl
2021-08-02 22:33 ` Darrick J. Wong
2021-08-03 16:15 ` Pavel Reichl [this message]
2021-08-02 21:50 ` [PATCH 3/8] xfsprogs: remove platform_uuid_compare() Pavel Reichl
2021-08-02 22:35 ` Darrick J. Wong
2021-08-03 16:07 ` Pavel Reichl
2021-08-02 21:50 ` [PATCH 4/8] xfsprogs: remove platform_{test_xfs_fd,path,fstatfs} Pavel Reichl
2021-08-02 22:31 ` Darrick J. Wong
2021-08-02 21:50 ` [PATCH 5/8] xfsprogs: Rename platform_getoptreset -> getoptreset Pavel Reichl
2021-08-02 21:50 ` [PATCH 6/8] xfsprogs: remove all platform_ prefixes in linux.h Pavel Reichl
2021-08-02 21:50 ` [PATCH 7/8] xfsprogs: Remove platform_ prefixes in libfrog/common.h Pavel Reichl
2021-08-02 21:50 ` [PATCH 8/8] xfsprogs: remove platform_ from man xfsctl man page Pavel Reichl
2021-08-02 22:24 ` [PATCH 0/8] xfsprogs: Drop the 'platform_' prefix Darrick J. Wong
2021-08-23 22:45 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce90e2cc-5098-9e9a-c083-16bb73eddd0b@redhat.com \
--to=preichl@redhat.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).