From: Allison Henderson <allison.henderson@oracle.com>
To: Brian Foster <bfoster@redhat.com>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 3/9] xfs: separate log cleaning from log quiesce
Date: Wed, 6 Jan 2021 15:50:49 -0700 [thread overview]
Message-ID: <f2f524bc-3657-aaea-8d97-eaf234384ac3@oracle.com> (raw)
In-Reply-To: <20210106174127.805660-4-bfoster@redhat.com>
On 1/6/21 10:41 AM, Brian Foster wrote:
> Log quiesce is currently associated with cleaning the log, which is
> accomplished by writing an unmount record as the last step of the
> quiesce sequence. The quiesce codepath is a bit convoluted in this
> regard due to how it is reused from various contexts. In preparation
> to create separate log cleaning and log covering interfaces, lift
> the write of the unmount record into a new cleaning helper and call
> that wherever xfs_log_quiesce() is currently invoked. No functional
> changes.
>
> Signed-off-by: Brian Foster <bfoster@redhat.com>
Looks ok to me
Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
> ---
> fs/xfs/xfs_log.c | 8 +++++++-
> fs/xfs/xfs_log.h | 1 +
> fs/xfs/xfs_super.c | 2 +-
> 3 files changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c
> index 4137ed007111..1b3227a033ad 100644
> --- a/fs/xfs/xfs_log.c
> +++ b/fs/xfs/xfs_log.c
> @@ -957,7 +957,13 @@ xfs_log_quiesce(
> xfs_wait_buftarg(mp->m_ddev_targp);
> xfs_buf_lock(mp->m_sb_bp);
> xfs_buf_unlock(mp->m_sb_bp);
> +}
>
> +void
> +xfs_log_clean(
> + struct xfs_mount *mp)
> +{
> + xfs_log_quiesce(mp);
> xfs_log_unmount_write(mp);
> }
>
> @@ -972,7 +978,7 @@ void
> xfs_log_unmount(
> struct xfs_mount *mp)
> {
> - xfs_log_quiesce(mp);
> + xfs_log_clean(mp);
>
> xfs_trans_ail_destroy(mp);
>
> diff --git a/fs/xfs/xfs_log.h b/fs/xfs/xfs_log.h
> index 98c913da7587..b0400589f824 100644
> --- a/fs/xfs/xfs_log.h
> +++ b/fs/xfs/xfs_log.h
> @@ -139,6 +139,7 @@ bool xfs_log_item_in_current_chkpt(struct xfs_log_item *lip);
>
> void xfs_log_work_queue(struct xfs_mount *mp);
> void xfs_log_quiesce(struct xfs_mount *mp);
> +void xfs_log_clean(struct xfs_mount *mp);
> bool xfs_log_check_lsn(struct xfs_mount *, xfs_lsn_t);
> bool xfs_log_in_recovery(struct xfs_mount *);
>
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index 813be879a5e5..09d956e30fd8 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -897,7 +897,7 @@ xfs_quiesce_attr(
> if (error)
> xfs_warn(mp, "xfs_attr_quiesce: failed to log sb changes. "
> "Frozen image may not be consistent.");
> - xfs_log_quiesce(mp);
> + xfs_log_clean(mp);
> }
>
> /*
>
next prev parent reply other threads:[~2021-01-06 22:51 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-06 17:41 [PATCH 0/9] xfs: rework log quiesce to cover the log Brian Foster
2021-01-06 17:41 ` [PATCH 1/9] xfs: sync lazy sb accounting on quiesce of read-only mounts Brian Foster
2021-01-06 22:50 ` Allison Henderson
2021-01-07 19:06 ` Darrick J. Wong
2021-01-11 17:38 ` Christoph Hellwig
2021-01-12 14:55 ` Brian Foster
2021-01-12 18:20 ` Christoph Hellwig
2021-01-21 15:08 ` Bill O'Donnell
2021-01-21 16:49 ` Darrick J. Wong
2021-01-21 17:17 ` Bill O'Donnell
2021-01-06 17:41 ` [PATCH 2/9] xfs: lift writable fs check up into log worker task Brian Foster
2021-01-06 22:50 ` Allison Henderson
2021-01-07 18:34 ` Darrick J. Wong
2021-01-07 19:53 ` Brian Foster
2021-01-07 21:28 ` Darrick J. Wong
2021-01-13 15:24 ` Christoph Hellwig
2021-01-06 17:41 ` [PATCH 3/9] xfs: separate log cleaning from log quiesce Brian Foster
2021-01-06 22:50 ` Allison Henderson [this message]
2021-01-07 19:07 ` Darrick J. Wong
2021-01-13 15:30 ` Christoph Hellwig
2021-01-06 17:41 ` [PATCH 4/9] xfs: cover the log during " Brian Foster
2021-01-07 19:04 ` Darrick J. Wong
2021-01-07 19:53 ` Brian Foster
2021-01-19 17:51 ` Darrick J. Wong
2021-01-19 15:35 ` Christoph Hellwig
2021-01-06 17:41 ` [PATCH 5/9] xfs: don't reset log idle state on covering checkpoints Brian Foster
2021-01-07 19:30 ` Darrick J. Wong
2021-01-07 20:01 ` Brian Foster
2021-01-06 17:41 ` [PATCH 6/9] xfs: fold sbcount quiesce logging into log covering Brian Foster
2021-01-07 19:31 ` Darrick J. Wong
2021-01-06 17:41 ` [PATCH 7/9] xfs: remove duplicate wq cancel and log force from attr quiesce Brian Foster
2021-01-07 19:38 ` Darrick J. Wong
2021-01-06 17:41 ` [PATCH 8/9] xfs: remove xfs_quiesce_attr() Brian Foster
2021-01-07 19:39 ` Darrick J. Wong
2021-01-06 17:41 ` [PATCH 9/9] xfs: cover the log on freeze instead of cleaning it Brian Foster
2021-01-07 19:39 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2f524bc-3657-aaea-8d97-eaf234384ac3@oracle.com \
--to=allison.henderson@oracle.com \
--cc=bfoster@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).