From: Eric Sandeen <sandeen@sandeen.net>
To: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Christoph Hellwig <hch@infradead.org>
Cc: Pavel Reichl <preichl@redhat.com>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH v3] mkfs: Break block discard into chunks of 2 GB
Date: Tue, 10 Dec 2019 08:20:42 -0600 [thread overview]
Message-ID: <fc7184ca-dfbe-9bf8-e790-405766f37bd8@sandeen.net> (raw)
In-Reply-To: <BYAPR04MB5749AF1A90B082FBD8662284865B0@BYAPR04MB5749.namprd04.prod.outlook.com>
On 12/10/19 1:33 AM, Chaitanya Kulkarni wrote:
> On 12/04/2019 09:42 AM, Darrick J. Wong wrote:
>> On Wed, Dec 04, 2019 at 09:26:52AM -0800, Christoph Hellwig wrote:
>>> On Wed, Dec 04, 2019 at 10:24:32AM -0600, Eric Sandeen wrote:
>>>> It'd be great to fix this universally in the kernel but it seems like
>>>> that patch is in discussion for now, and TBH I don't see any real
>>>> drawbacks to looping in mkfs - it would also solve the problem on any
>>>> old kernel w/o the block layer change.
>>>
>>> The problem is that we throw out efficiency for no good reason.
>>
>> True...
>>
>>>> I'd propose that we go ahead w/ the mkfs change, and if/when the kernel
>>>> handles this better, and it's reasonable to expect that we're running
>>
>> How do we detect that the kernel will handle it better?
>
>>
>>>> on a kernel where it can be interrupted, we could remove the mkfs loop
>>>> at a later date if we wanted to.
>>>
>>> I'd rather not touch mkfs if a trivial kernel patch handles the issue.
>>
>> Did some version of Tetsuo's patch even make it for 5.5? It seemed to
>> call submit_bio_wait from within a blk_plug region, which seems way
>> worse.
>>
>
> It did not yet, I can ping on the series with reference to this discussion.
That's fine, though I'm going to merge this patch in any case; we need a solution
for kernels that are not bleeding-edge new as well.
-eric
next prev parent reply other threads:[~2019-12-10 14:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-28 6:21 [PATCH v3] mkfs: Break block discard into chunks of 2 GB Pavel Reichl
2019-11-30 22:01 ` Chaitanya Kulkarni
2019-12-02 16:40 ` Darrick J. Wong
2019-12-04 16:24 ` Eric Sandeen
2019-12-04 17:26 ` Christoph Hellwig
2019-12-04 17:32 ` Eric Sandeen
2019-12-04 17:42 ` Darrick J. Wong
2019-12-10 7:33 ` Chaitanya Kulkarni
2019-12-10 14:20 ` Eric Sandeen [this message]
2019-12-09 22:00 ` Eric Sandeen
2019-12-09 23:34 ` Darrick J. Wong
2019-12-10 0:49 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc7184ca-dfbe-9bf8-e790-405766f37bd8@sandeen.net \
--to=sandeen@sandeen.net \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=preichl@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).