From: Christophe Leroy <christophe.leroy@c-s.fr>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: "linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>
Subject: Re: RESEND: Re: Problem booting a PowerBook G4 Aluminum after commit cd08f109 with CONFIG_VMAP_STACK=y
Date: Fri, 14 Feb 2020 19:35:43 +0000 [thread overview]
Message-ID: <074f2468-1fbe-0714-df58-b6d2e1d2725b@c-s.fr> (raw)
In-Reply-To: <f3f628ca-4085-e9c2-2c62-170cf9801ac2@lwfinger.net>
On 02/14/2020 06:24 PM, Larry Finger wrote:
> On 2/14/20 12:24 AM, Christophe Leroy wrote:
>>
>> Did you try with the patch at
>> https://patchwork.ozlabs.org/patch/1237387/ ?
>
> Christophe,
>
> When I apply that patch, there is an error at
>
> --- a/arch/powerpc/kernel/head_32.S
> +++ b/arch/powerpc/kernel/head_32.S
> @@ -301,6 +301,39 @@ MachineCheck:
> . = 0x300
> DO_KVM 0x300
> DataAccess:
>
> It complains about "an attempt to move .org backwards".
>
Argh !
> When I change the 0x300 to 0x310 in two places, it builds OK. Is that OK?
No you can't do that.
The following should solve it for your case.
---
diff --git a/arch/powerpc/kernel/head_32.S b/arch/powerpc/kernel/head_32.S
index 32875afb3319..f9941b766f63 100644
--- a/arch/powerpc/kernel/head_32.S
+++ b/arch/powerpc/kernel/head_32.S
@@ -270,6 +270,9 @@ __secondary_hold_acknowledge:
* pointer when we take an exception from supervisor mode.)
* -- paulus.
*/
+#ifdef CONFIG_PPC_CHRP
+1: b machine_check_in_rtas
+#endif
. = 0x200
DO_KVM 0x200
MachineCheck:
@@ -290,12 +293,9 @@ MachineCheck:
7: EXCEPTION_PROLOG_2
addi r3,r1,STACK_FRAME_OVERHEAD
#ifdef CONFIG_PPC_CHRP
- bne cr1,1f
+ bne cr1,1b
#endif
EXC_XFER_STD(0x200, machine_check_exception)
-#ifdef CONFIG_PPC_CHRP
-1: b machine_check_in_rtas
-#endif
/* Data access exception. */
. = 0x300
---
Christophe
next prev parent reply other threads:[~2020-02-14 20:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <f7565b89-c8b2-d2e7-929e-4b1abf72fc63@lwfinger.net>
[not found] ` <159ed5d8-376b-1642-fb4b-01406d671cf1@c-s.fr>
[not found] ` <6a1802b8-c6a7-d091-1036-689e089b786f@lwfinger.net>
2020-02-11 6:55 ` Problem booting a PowerBook G4 Aluminum after commit cd08f109 with CONFIG_VMAP_STACK=y Christophe Leroy
2020-02-11 16:06 ` Larry Finger
2020-02-11 19:23 ` Christophe Leroy
[not found] ` <1787b507-dfbf-7801-f7d4-a1547e9bd588@lwfinger.net>
2020-02-13 11:23 ` Christophe Leroy
[not found] ` <7f63e8a8-95c5-eeca-dc79-3c13f4d98d39@lwfinger.net>
2020-02-13 14:43 ` RESEND: " Christophe Leroy
2020-02-13 23:09 ` Larry Finger
2020-02-14 6:24 ` Christophe Leroy
2020-02-14 11:02 ` Christophe Leroy
2020-02-14 18:20 ` Larry Finger
2020-02-14 18:24 ` Larry Finger
2020-02-14 19:35 ` Christophe Leroy [this message]
2020-02-15 2:42 ` Larry Finger
2020-02-15 7:55 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=074f2468-1fbe-0714-df58-b6d2e1d2725b@c-s.fr \
--to=christophe.leroy@c-s.fr \
--cc=Larry.Finger@lwfinger.net \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).