From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: Oliver O'Halloran <oohall@gmail.com>, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/powernv: Escalate reset when IODA reset fails
Date: Mon, 4 Feb 2019 15:44:58 +1100 [thread overview]
Message-ID: <0b323d19-c197-aa66-3d0a-344a5af39789@ozlabs.ru> (raw)
In-Reply-To: <20190201004201.6512-1-oohall@gmail.com>
On 01/02/2019 11:42, Oliver O'Halloran wrote:
> The IODA reset is used to flush out any OS controlled state from the PHB.
> This reset can fail if a PHB fatal error has occurred in early boot,
> probably due to a because of a bad device. We already do a fundemental
> reset of the device in some cases, so this patch just adds a test to force
> a full reset if firmware reports an error when performing the IODA reset.
>
> Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
I am pretty sure I already saw this :-/
ah, anyway
Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
> arch/powerpc/platforms/powernv/pci-ioda.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c b/arch/powerpc/platforms/powernv/pci-ioda.c
> index 1d6406a..53982f8 100644
> --- a/arch/powerpc/platforms/powernv/pci-ioda.c
> +++ b/arch/powerpc/platforms/powernv/pci-ioda.c
> @@ -3943,9 +3943,12 @@ static void __init pnv_pci_init_ioda_phb(struct device_node *np,
> * shutdown PCI devices correctly. We already got IODA table
> * cleaned out. So we have to issue PHB reset to stop all PCI
> * transactions from previous kernel. The ppc_pci_reset_phbs
> - * kernel parameter will force this reset too.
> + * kernel parameter will force this reset too. Additionally,
> + * if the IODA reset above failed then use a bigger hammer.
> + * This can happen if we get a PHB fatal error in very early
> + * boot.
> */
> - if (is_kdump_kernel() || pci_reset_phbs) {
> + if (is_kdump_kernel() || pci_reset_phbs || rc) {
> pr_info(" Issue PHB reset ...\n");
> pnv_eeh_phb_reset(hose, EEH_RESET_FUNDAMENTAL);
> pnv_eeh_phb_reset(hose, EEH_RESET_DEACTIVATE);
>
--
Alexey
next prev parent reply other threads:[~2019-02-04 4:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-01 0:42 [PATCH] powerpc/powernv: Escalate reset when IODA reset fails Oliver O'Halloran
2019-02-04 4:44 ` Alexey Kardashevskiy [this message]
2019-02-04 6:04 ` Oliver
2019-02-08 13:02 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b323d19-c197-aa66-3d0a-344a5af39789@ozlabs.ru \
--to=aik@ozlabs.ru \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=oohall@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).