From: Geoff Levand <geoff@infradead.org>
To: Yue Haibing <yuehaibing@huawei.com>,
perex@perex.cz, tiwai@suse.com, benh@kernel.crashing.org,
paulus@samba.org, mpe@ellerman.id.au
Cc: alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] ALSA: ps3: Remove set but not used variables 'start_vaddr' and 'pcm_index'
Date: Wed, 17 Apr 2019 11:19:30 -0700 [thread overview]
Message-ID: <1078ccec-2cc9-f16d-caca-32ac9c3cce4d@infradead.org> (raw)
In-Reply-To: <20190417145722.20448-1-yuehaibing@huawei.com>
On 4/17/19 7:57 AM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fixes gcc '-Wunused-but-set-variable' warnings:
>
> sound/ppc/snd_ps3.c: In function 'snd_ps3_program_dma':
> sound/ppc/snd_ps3.c:236:8: warning: variable 'start_vaddr' set but not used [-Wunused-but-set-variable]
> sound/ppc/snd_ps3.c: In function 'snd_ps3_pcm_open':
> sound/ppc/snd_ps3.c:529:6: warning: variable 'pcm_index' set but not used [-Wunused-but-set-variable]
>
> They are never used and can be removed.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> sound/ppc/snd_ps3.c | 4 ----
> 1 file changed, 4 deletions(-)
Seems OK. Thanks for submitting.
Acked-by: Geoff Levand <geoff@infradead.org>
next prev parent reply other threads:[~2019-04-17 18:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 14:57 [PATCH -next] ALSA: ps3: Remove set but not used variables 'start_vaddr' and 'pcm_index' Yue Haibing
2019-04-17 18:19 ` Geoff Levand [this message]
2019-04-17 19:18 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1078ccec-2cc9-f16d-caca-32ac9c3cce4d@infradead.org \
--to=geoff@infradead.org \
--cc=alsa-devel@alsa-project.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).