From: Scott Wood <scottwood@freescale.com>
To: Tiejun Chen <tiejun.chen@windriver.com>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [v5][PATCH 4/6] powerpc/book3e: support kgdb for kernel space
Date: Fri, 18 Oct 2013 17:58:39 -0500 [thread overview]
Message-ID: <1382137119.7979.916.camel@snotra.buserror.net> (raw)
In-Reply-To: <1371724110-8250-5-git-send-email-tiejun.chen@windriver.com>
On Thu, 2013-06-20 at 18:28 +0800, Tiejun Chen wrote:
> Currently we need to skip this for supporting KGDB.
Does it need to depend on CONFIG_KGDB? Either you've fixed the "can't
quite save properly" part, or you haven't.
-Scott
>
> Signed-off-by: Tiejun Chen <tiejun.chen@windriver.com>
> ---
> arch/powerpc/kernel/exceptions-64e.S | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kernel/exceptions-64e.S b/arch/powerpc/kernel/exceptions-64e.S
> index 07cf657..a286b51 100644
> --- a/arch/powerpc/kernel/exceptions-64e.S
> +++ b/arch/powerpc/kernel/exceptions-64e.S
> @@ -639,11 +639,13 @@ kernel_dbg_exc:
> rfdi
>
> /* Normal debug exception */
> +1: andi. r14,r11,MSR_PR; /* check for userspace again */
> +#ifndef CONFIG_KGDB
> /* XXX We only handle coming from userspace for now since we can't
> * quite save properly an interrupted kernel state yet
> */
> -1: andi. r14,r11,MSR_PR; /* check for userspace again */
> beq kernel_dbg_exc; /* if from kernel mode */
> +#endif
>
> /* Now we mash up things to make it look like we are coming on a
> * normal exception
next prev parent reply other threads:[~2013-10-18 22:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 10:28 [v5][PATCH 0/6] powerpc/book3e: powerpc/book3e: make kgdb to work well Tiejun Chen
2013-06-20 10:28 ` [v5][PATCH 1/6] powerpc/book3e: load critical/machine/debug exception stack Tiejun Chen
2013-10-18 22:37 ` Scott Wood
2013-10-23 9:26 ` "“tiejun.chen”"
2013-10-18 23:55 ` Scott Wood
2013-10-23 9:28 ` "“tiejun.chen”"
2013-06-20 10:28 ` [v5][PATCH 2/6] powerpc/book3e: store critical/machine/debug exception thread info Tiejun Chen
2013-10-18 22:43 ` Scott Wood
2013-10-23 9:27 ` "“tiejun.chen”"
2013-06-20 10:28 ` [v5][PATCH 3/6] book3e/kgdb: update thread's dbcr0 Tiejun Chen
2013-10-18 22:57 ` Scott Wood
2013-10-23 9:27 ` "“tiejun.chen”"
2013-06-20 10:28 ` [v5][PATCH 4/6] powerpc/book3e: support kgdb for kernel space Tiejun Chen
2013-10-18 22:58 ` Scott Wood [this message]
2013-10-23 9:27 ` "“tiejun.chen”"
2013-06-20 10:28 ` [v5][PATCH 5/6] powerpc/kgdb: use DEFINE_PER_CPU to allocate kgdb's thread_info Tiejun Chen
2013-06-20 10:28 ` [v5][PATCH 6/6] book3e/kgdb: Fix a single stgep case of lazy IRQ Tiejun Chen
2013-10-18 23:32 ` Scott Wood
2013-10-23 9:28 ` "“tiejun.chen”"
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382137119.7979.916.camel@snotra.buserror.net \
--to=scottwood@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=tiejun.chen@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).