From: "Alastair D'Silva" <alastair@au1.ibm.com>
To: Frederic Barrat <fbarrat@linux.ibm.com>,
linuxppc-dev@lists.ozlabs.org, andrew.donnellan@au1.ibm.com,
clombard@linux.ibm.com
Cc: groug@kaod.org
Subject: Re: [PATCH 09/11] pci/hotplug/pnv-php: Relax check when disabling slot
Date: Tue, 10 Sep 2019 11:00:55 +1000 [thread overview]
Message-ID: <14004d6ca963ece9f0f1ab844c899035b6e970bb.camel@au1.ibm.com> (raw)
In-Reply-To: <20190909154600.19917-10-fbarrat@linux.ibm.com>
On Mon, 2019-09-09 at 17:45 +0200, Frederic Barrat wrote:
> The driver only allows to disable a slot in the POPULATED
> state. However, if an error occurs while enabling the slot, say
> because the link couldn't be trained, then the POPULATED state may
> not
> be reached, yet the power state of the slot is on. So allow to
> disable
> a slot in the REGISTERED state. Removing the devices will do nothing
> since it's not populated, and we'll set the power state of the slot
> back to off.
>
> Signed-off-by: Frederic Barrat <fbarrat@linux.ibm.com>
> ---
> drivers/pci/hotplug/pnv_php.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/hotplug/pnv_php.c
> b/drivers/pci/hotplug/pnv_php.c
> index f0a7360154e7..5ca51d67db4b 100644
> --- a/drivers/pci/hotplug/pnv_php.c
> +++ b/drivers/pci/hotplug/pnv_php.c
> @@ -523,7 +523,13 @@ static int pnv_php_disable_slot(struct
> hotplug_slot *slot)
> struct pnv_php_slot *php_slot = to_pnv_php_slot(slot);
> int ret;
>
> - if (php_slot->state != PNV_PHP_STATE_POPULATED)
> + /*
> + * Allow to disable a slot already in the registered state to
> + * cover cases where the slot couldn't be enabled and never
> + * reached the populated state
> + */
> + if (php_slot->state != PNV_PHP_STATE_POPULATED &&
> + php_slot->state != PNV_PHP_STATE_REGISTERED)
> return 0;
>
> /* Remove all devices behind the slot */
Reviewed-by: Alastair D'Silva <alastair@d-silva.org>
--
Alastair D'Silva
Open Source Developer
Linux Technology Centre, IBM Australia
mob: 0423 762 819
next prev parent reply other threads:[~2019-09-10 1:07 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 15:45 [PATCH 00/11] opencapi: enable card reset and link retraining Frederic Barrat
2019-09-09 15:45 ` [PATCH 01/11] powerpc/powernv/ioda: Fix ref count for devices with their own PE Frederic Barrat
2019-09-10 0:20 ` Alastair D'Silva
2019-09-26 16:44 ` Andrew Donnellan
2019-09-26 17:15 ` Frederic Barrat
2019-09-27 6:54 ` Alexey Kardashevskiy
2019-11-12 17:38 ` Frederic Barrat
2019-11-18 1:04 ` Alistair Popple
2019-11-18 1:24 ` Oliver O'Halloran
2019-11-18 2:36 ` Alistair Popple
2019-11-18 18:21 ` Frederic Barrat
2019-09-09 15:45 ` [PATCH 02/11] powerpc/powernv/ioda: Protect PE list Frederic Barrat
2019-09-10 0:34 ` Alastair D'Silva
2019-11-19 12:55 ` Frederic Barrat
2019-11-19 13:22 ` Oliver O'Halloran
2019-11-19 14:36 ` Frederic Barrat
2019-11-19 5:55 ` Andrew Donnellan
2019-09-09 15:45 ` [PATCH 03/11] powerpc/powernv/ioda: set up PE on opencapi device when enabling Frederic Barrat
2019-09-10 0:38 ` Alastair D'Silva
2019-09-27 16:43 ` Andrew Donnellan
2019-09-09 15:45 ` [PATCH 04/11] powerpc/powernv/ioda: Release opencapi device Frederic Barrat
2019-09-10 0:56 ` Alastair D'Silva
2019-11-19 17:32 ` Frederic Barrat
2019-11-19 7:08 ` Andrew Donnellan
2019-09-09 15:45 ` [PATCH 05/11] powerpc/powernv/ioda: Find opencapi slot for a device node Frederic Barrat
2019-09-10 0:57 ` Alastair D'Silva
2019-11-19 1:26 ` Andrew Donnellan
2019-11-19 14:33 ` Frederic Barrat
2019-09-09 15:45 ` [PATCH 06/11] pci/hotplug/pnv-php: Remove erroneous warning Frederic Barrat
2019-09-10 0:58 ` Alastair D'Silva
2019-11-19 5:00 ` Andrew Donnellan
2019-09-09 15:45 ` [PATCH 07/11] pci/hotplug/pnv-php: Improve error msg on power state change failure Frederic Barrat
2019-09-10 0:59 ` Alastair D'Silva
2019-11-19 2:23 ` Andrew Donnellan
2019-09-09 15:45 ` [PATCH 08/11] pci/hotplug/pnv-php: Register opencapi slots Frederic Barrat
2019-09-10 1:00 ` Alastair D'Silva
2019-11-19 5:18 ` Andrew Donnellan
2019-11-19 15:15 ` Frederic Barrat
2019-09-09 15:45 ` [PATCH 09/11] pci/hotplug/pnv-php: Relax check when disabling slot Frederic Barrat
2019-09-10 1:00 ` Alastair D'Silva [this message]
2019-09-27 15:56 ` Andrew Donnellan
2019-09-09 15:45 ` [PATCH 10/11] pci/hotplug/pnv-php: Wrap warnings in macro Frederic Barrat
2019-09-10 1:03 ` Alastair D'Silva
2019-09-26 17:18 ` Andrew Donnellan
2019-09-09 15:46 ` [PATCH 11/11] ocxl: Add PCI hotplug dependency to Kconfig Frederic Barrat
2019-09-10 1:03 ` Alastair D'Silva
2019-09-26 17:11 ` Andrew Donnellan
2019-09-24 4:24 ` [PATCH 00/11] opencapi: enable card reset and link retraining Alexey Kardashevskiy
2019-09-24 6:39 ` Frederic Barrat
2019-09-25 0:20 ` Alexey Kardashevskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14004d6ca963ece9f0f1ab844c899035b6e970bb.camel@au1.ibm.com \
--to=alastair@au1.ibm.com \
--cc=andrew.donnellan@au1.ibm.com \
--cc=clombard@linux.ibm.com \
--cc=fbarrat@linux.ibm.com \
--cc=groug@kaod.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).