From: Nicholas Piggin <npiggin@gmail.com>
To: Paul Mackerras <paulus@ozlabs.org>
Cc: "Gautham R . Shenoy" <ego@linux.vnet.ibm.com>,
Mahesh Jagannath Salgaonkar <mahesh@linux.vnet.ibm.com>,
kvm-ppc@vger.kernel.org,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org,
Akshay Adiga <akshay.adiga@linux.vnet.ibm.com>
Subject: Re: [PATCH v6] powerpc/64s: reimplement book3s idle code in C
Date: Tue, 19 Feb 2019 14:13:51 +1000 [thread overview]
Message-ID: <1550549470.22tqiqz5em.astroid@bobo.none> (raw)
In-Reply-To: <20190217230640.GA922@blackberry>
Paul Mackerras's on February 18, 2019 9:06 am:
> On Sat, Oct 13, 2018 at 10:04:09PM +1000, Nicholas Piggin wrote:
>> Reimplement Book3S idle code in C, moving POWER7/8/9 implementation
>> speific HV idle code to the powernv platform code.
>>
>
> [...]
>
>> @@ -2760,21 +2744,47 @@ BEGIN_FTR_SECTION
>> li r4, LPCR_PECE_HVEE@higher
>> sldi r4, r4, 32
>> or r5, r5, r4
>> -END_FTR_SECTION_IFSET(CPU_FTR_ARCH_300)
>> +FTR_SECTION_ELSE
>> + li r3, PNV_THREAD_NAP
>> +ALT_FTR_SECTION_END_IFSET(CPU_FTR_ARCH_300)
>> mtspr SPRN_LPCR,r5
>> isync
>> - li r0, 0
>> - std r0, HSTATE_SCRATCH0(r13)
>> - ptesync
>> - ld r0, HSTATE_SCRATCH0(r13)
>> -1: cmpd r0, r0
>> - bne 1b
>> +
>> + mr r0, r1
>> + ld r1, PACAEMERGSP(r13)
>> + subi r1, r1, STACK_FRAME_OVERHEAD
>> + std r0, 0(r1)
>> + ld r0, PACAR1(r13)
>> + std r0, 8(r1)
>
> This bit seems wrong to me. If this is a secondary thread on POWER8,
> we were already on the emergency stack, and now we've reset r1 back to
> the top of the emergency stack and we're overwriting it.
I'll have to find some time to take another look at this stuff. The KVM
stuff was a bit hasty.
> I wonder why you didn't see secondary threads going off into lala land
> in your tests?
It must have been because I wasn't testing the guest SMT properly
because I did get it to break trivially sometime after posting this
patch out. So we were on the emergency stack here, that should make
things easier, that may be what's wrong.
Thanks,
Nick
next prev parent reply other threads:[~2019-02-19 4:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-13 12:04 [PATCH v6] powerpc/64s: reimplement book3s idle code in C Nicholas Piggin
2019-02-17 23:06 ` Paul Mackerras
2019-02-19 4:13 ` Nicholas Piggin [this message]
2019-02-20 0:59 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1550549470.22tqiqz5em.astroid@bobo.none \
--to=npiggin@gmail.com \
--cc=akshay.adiga@linux.vnet.ibm.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=ego@linux.vnet.ibm.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.vnet.ibm.com \
--cc=paulus@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).