From: Nicholas Piggin <npiggin@gmail.com>
To: Christophe Leroy <christophe.leroy@c-s.fr>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/64s: Make boot look nice(r)
Date: Thu, 16 May 2019 16:08:26 +1000 [thread overview]
Message-ID: <1557986563.56odablyi5.astroid@bobo.none> (raw)
In-Reply-To: <d65ae686-c117-ae1c-1d48-498fdd1ea0eb@c-s.fr>
Christophe Leroy's on May 16, 2019 2:47 pm:
>
>
> Le 16/05/2019 à 04:04, Nicholas Piggin a écrit :
>> Radix boot looks like this:
>>
>> -----------------------------------------------------
>> phys_mem_size = 0x200000000
>> dcache_bsize = 0x80
>> icache_bsize = 0x80
>> cpu_features = 0x0000c06f8f5fb1a7
>> possible = 0x0000fbffcf5fb1a7
>> always = 0x00000003800081a1
>> cpu_user_features = 0xdc0065c2 0xaee00000
>> mmu_features = 0xbc006041
>> firmware_features = 0x0000000010000000
>> hash-mmu: ppc64_pft_size = 0x0
>> hash-mmu: kernel vmalloc start = 0xc008000000000000
>> hash-mmu: kernel IO start = 0xc00a000000000000
>> hash-mmu: kernel vmemmap start = 0xc00c000000000000
>> -----------------------------------------------------
>>
>> Fix:
>>
>> -----------------------------------------------------
>> phys_mem_size = 0x200000000
>> dcache_bsize = 0x80
>> icache_bsize = 0x80
>> cpu_features = 0x0000c06f8f5fb1a7
>> possible = 0x0000fbffcf5fb1a7
>> always = 0x00000003800081a1
>> cpu_user_features = 0xdc0065c2 0xaee00000
>> mmu_features = 0xbc006041
>> firmware_features = 0x0000000010000000
>> vmalloc start = 0xc008000000000000
>> IO start = 0xc00a000000000000
>> vmemmap start = 0xc00c000000000000
>> -----------------------------------------------------
>>
>> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
>
> I fear your change defeats most of the purpose of commit
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20190515&id=e4dccf9092ab48a6f902003b9558c0e45d0e849a
I think it's still a significant improvement without introducing
the regression :)
> As far as I understand, the main issue is the "hash-mmu:" prefix ?
> That's due to the following define in top of book3s64/hash_utils.c:
>
> #define pr_fmt(fmt) "hash-mmu: " fmt
>
> Could we simply undef it just before print_system_hash_info() ?
Little bit fragile I think.
> Or move print_system_hash_info() in another book3s64 specific file which
> doesn't set pr_fmt ?
print_system_info() would be okay for me and allow getting rid of
that PPC64 config. Although it also needs to go in a file without
pr_fmt I guess that's not so hard.
Thanks,
Nick
next prev parent reply other threads:[~2019-05-16 6:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-16 2:04 [PATCH] powerpc/64s: Make boot look nice(r) Nicholas Piggin
2019-05-16 4:47 ` Christophe Leroy
2019-05-16 6:08 ` Nicholas Piggin [this message]
2019-05-17 3:18 ` Thiago Jung Bauermann
2019-08-10 10:20 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1557986563.56odablyi5.astroid@bobo.none \
--to=npiggin@gmail.com \
--cc=christophe.leroy@c-s.fr \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).