From: Shawn Guo <shawnguo@kernel.org>
To: Vabhav Sharma <vabhav.sharma@nxp.com>
Cc: mark.rutland@arm.com, kstewart@linuxfoundation.org,
linux-kernel-owner@vger.kernel.org, catalin.marinas@arm.com,
mturquette@baylibre.com, will.deacon@arm.com,
yamada.masahiro@socionext.com, Sriram Dash <sriram.dash@nxp.com>,
linux-clk@vger.kernel.org, pankaj.bansal@nxp.com,
udit.kumar@nxp.com, linux@armlinux.org.uk,
Priyanka Jain <priyanka.jain@nxp.com>,
viresh.kumar@linaro.org, devicetree@vger.kernel.org,
arnd@arndb.de, linux-pm@vger.kernel.org, oss@buserror.net,
robh+dt@kernel.org, V.Sethi@nxp.com,
linux-arm-kernel@lists.infradead.org, sboyd@kernel.org,
gregkh@linuxfoundation.org, rjw@rjwysocki.net,
linux-kernel@vger.kernel.org, leoyang.li@nxp.com,
sudeep.holla@arm.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v4 6/6] arm64: dts: add LX2160ARDB board support
Date: Mon, 8 Oct 2018 13:52:01 +0800 [thread overview]
Message-ID: <20181008055159.GH3587@dragon> (raw)
In-Reply-To: <1538615031-7507-7-git-send-email-vabhav.sharma@nxp.com>
On Thu, Oct 04, 2018 at 06:33:51AM +0530, Vabhav Sharma wrote:
> LX2160A reference design board (RDB) is a high-performance
> computing, evaluation, and development platform with LX2160A
> SoC.
>
> Signed-off-by: Priyanka Jain <priyanka.jain@nxp.com>
> Signed-off-by: Sriram Dash <sriram.dash@nxp.com>
> Signed-off-by: Vabhav Sharma <vabhav.sharma@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/Makefile | 1 +
> arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 100 ++++++++++++++++++++++
> 2 files changed, 101 insertions(+)
> create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
>
> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> index 86e18ad..445b72b 100644
> --- a/arch/arm64/boot/dts/freescale/Makefile
> +++ b/arch/arm64/boot/dts/freescale/Makefile
> @@ -13,3 +13,4 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-rdb.dtb
> dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-simu.dtb
> dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2088a-qds.dtb
> dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2088a-rdb.dtb
> +dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-rdb.dtb
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> new file mode 100644
> index 0000000..1483071
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> @@ -0,0 +1,100 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +//
> +// Device Tree file for LX2160ARDB
> +//
> +// Copyright 2018 NXP
> +
> +/dts-v1/;
> +
> +#include "fsl-lx2160a.dtsi"
> +
> +/ {
> + model = "NXP Layerscape LX2160ARDB";
> + compatible = "fsl,lx2160a-rdb", "fsl,lx2160a";
> +
> + chosen {
> + stdout-path = "serial0:115200n8";
> + };
> +
> + sb_3v3: regulator-fixed {
The node name should probably be named like regulator-sb3v3 or
something, so that the pattern can be followed when we have another
fixed regulator to be added.
> + compatible = "regulator-fixed";
> + regulator-name = "fixed-3.3V";
The name should be something we can find on board schematics.
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-boot-on;
> + regulator-always-on;
> + };
> +
> +};
> +
> +&uart0 {
> + status = "okay";
> +};
> +
> +&uart1 {
> + status = "okay";
> +};
> +
> +&i2c0 {
Please keep these labeled nodes sorted alphabetically.
> + status = "okay";
Have a newline between properties and child node.
> + i2c-mux@77 {
> + compatible = "nxp,pca9547";
> + reg = <0x77>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + i2c@2 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x2>;
> +
> + power-monitor@40 {
> + compatible = "ti,ina220";
> + reg = <0x40>;
> + shunt-resistor = <1000>;
> + };
> + };
> +
> + i2c@3 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x3>;
> +
> + temperature-sensor@4c {
> + compatible = "nxp,sa56004";
> + reg = <0x4c>;
> + vcc-supply = <&sb_3v3>;
> + };
> +
> + temperature-sensor@4d {
> + compatible = "nxp,sa56004";
> + reg = <0x4d>;
> + vcc-supply = <&sb_3v3>;
> + };
> + };
> + };
> +};
> +
> +&i2c4 {
> + status = "okay";
> +
> + rtc@51 {
> + compatible = "nxp,pcf2129";
> + reg = <0x51>;
> + // IRQ10_B
> + interrupts = <0 150 0x4>;
> + };
Bad indentation.
Shawn
> +
> +};
> +
> +&usb0 {
> + status = "okay";
> +};
> +
> +&usb1 {
> + status = "okay";
> +};
> +
> +&crypto {
> + status = "okay";
> +};
> --
> 2.7.4
>
next prev parent reply other threads:[~2018-10-08 7:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 1:03 [PATCH v4 0/6] arm64: dts: NXP: add basic dts file for LX2160A SoC Vabhav Sharma
2018-10-04 1:03 ` [PATCH v4 1/6] dt-bindings: arm64: add compatible for LX2160A Vabhav Sharma
2018-10-04 1:03 ` [PATCH v4 2/6] soc/fsl/guts: Add compatible string " Vabhav Sharma
2018-10-04 1:03 ` [PATCH v4 3/6] clk: qoriq: increase array size of cmux_to_group Vabhav Sharma
2018-10-04 1:03 ` [PATCH v4 4/6] clk: qoriq: Add clockgen support for lx2160a Vabhav Sharma
2018-10-05 3:53 ` Viresh Kumar
2018-10-04 1:03 ` [PATCH v4 5/6] arm64: dts: add QorIQ LX2160A SoC support Vabhav Sharma
2018-10-08 5:45 ` Shawn Guo
2018-10-15 2:58 ` Vabhav Sharma
2018-10-15 16:48 ` Stephen Boyd
2018-10-25 4:19 ` Vabhav Sharma
2018-10-04 1:03 ` [PATCH v4 6/6] arm64: dts: add LX2160ARDB board support Vabhav Sharma
2018-10-08 5:52 ` Shawn Guo [this message]
2018-10-15 2:44 ` Vabhav Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181008055159.GH3587@dragon \
--to=shawnguo@kernel.org \
--cc=V.Sethi@nxp.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kstewart@linuxfoundation.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel-owner@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=oss@buserror.net \
--cc=pankaj.bansal@nxp.com \
--cc=priyanka.jain@nxp.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sriram.dash@nxp.com \
--cc=sudeep.holla@arm.com \
--cc=udit.kumar@nxp.com \
--cc=vabhav.sharma@nxp.com \
--cc=viresh.kumar@linaro.org \
--cc=will.deacon@arm.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).