From: kbuild test robot <lkp@intel.com>
To: Russell Currey <ruscur@russell.cc>
Cc: mikey@neuling.org, linuxppc-dev@lists.ozlabs.org, kbuild-all@01.org
Subject: Re: [PATCH 1/5] powerpc/64s: Kernel Hypervisor Restricted Access Prevention
Date: Wed, 17 Oct 2018 18:07:04 +0800 [thread overview]
Message-ID: <201810171821.TOPFrPj5%fengguang.wu@intel.com> (raw)
In-Reply-To: <20181017064422.26119-1-ruscur@russell.cc>
[-- Attachment #1: Type: text/plain, Size: 6120 bytes --]
Hi Russell,
I love your patch! Yet something to improve:
[auto build test ERROR on powerpc/next]
[also build test ERROR on next-20181016]
[cannot apply to v4.19-rc8]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Russell-Currey/powerpc-64s-Kernel-Hypervisor-Restricted-Access-Prevention/20181017-153543
base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-storcenter_defconfig (attached as .config)
compiler: powerpc-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=powerpc
All errors (new ones prefixed by >>):
In file included from include/linux/uaccess.h:14:0,
from net/core/datagram.c:40:
arch/powerpc/include/asm/uaccess.h: In function 'unlock_user_access':
>> arch/powerpc/include/asm/uaccess.h:69:6: error: implicit declaration of function 'mmu_has_feature'; did you mean 'firmware_has_feature'? [-Werror=implicit-function-declaration]
if (mmu_has_feature(MMU_FTR_RADIX_KHRAP)) {
^~~~~~~~~~~~~~~
firmware_has_feature
>> arch/powerpc/include/asm/uaccess.h:69:22: error: 'MMU_FTR_RADIX_KHRAP' undeclared (first use in this function); did you mean 'CPU_FTR_CAN_NAP'?
if (mmu_has_feature(MMU_FTR_RADIX_KHRAP)) {
^~~~~~~~~~~~~~~~~~~
CPU_FTR_CAN_NAP
arch/powerpc/include/asm/uaccess.h:69:22: note: each undeclared identifier is reported only once for each function it appears in
arch/powerpc/include/asm/uaccess.h: In function 'lock_user_access':
arch/powerpc/include/asm/uaccess.h:83:22: error: 'MMU_FTR_RADIX_KHRAP' undeclared (first use in this function); did you mean 'CPU_FTR_CAN_NAP'?
if (mmu_has_feature(MMU_FTR_RADIX_KHRAP)) {
^~~~~~~~~~~~~~~~~~~
CPU_FTR_CAN_NAP
In file included from include/linux/mm_types.h:18:0,
from include/linux/mm.h:17,
from net/core/datagram.c:41:
arch/powerpc/include/asm/mmu.h: At top level:
>> arch/powerpc/include/asm/mmu.h:209:20: error: conflicting types for 'mmu_has_feature'
static inline bool mmu_has_feature(unsigned long feature)
^~~~~~~~~~~~~~~
In file included from include/linux/uaccess.h:14:0,
from net/core/datagram.c:40:
arch/powerpc/include/asm/uaccess.h:69:6: note: previous implicit declaration of 'mmu_has_feature' was here
if (mmu_has_feature(MMU_FTR_RADIX_KHRAP)) {
^~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
--
In file included from include/linux/uaccess.h:14:0,
from include/linux/crypto.h:26,
from include/crypto/skcipher.h:16,
from include/crypto/chacha20.h:9,
from lib/chacha20.c:17:
arch/powerpc/include/asm/uaccess.h: In function 'unlock_user_access':
>> arch/powerpc/include/asm/uaccess.h:69:6: error: implicit declaration of function 'mmu_has_feature'; did you mean 'firmware_has_feature'? [-Werror=implicit-function-declaration]
if (mmu_has_feature(MMU_FTR_RADIX_KHRAP)) {
^~~~~~~~~~~~~~~
firmware_has_feature
>> arch/powerpc/include/asm/uaccess.h:69:22: error: 'MMU_FTR_RADIX_KHRAP' undeclared (first use in this function); did you mean 'CPU_FTR_CAN_NAP'?
if (mmu_has_feature(MMU_FTR_RADIX_KHRAP)) {
^~~~~~~~~~~~~~~~~~~
CPU_FTR_CAN_NAP
arch/powerpc/include/asm/uaccess.h:69:22: note: each undeclared identifier is reported only once for each function it appears in
arch/powerpc/include/asm/uaccess.h: In function 'lock_user_access':
arch/powerpc/include/asm/uaccess.h:83:22: error: 'MMU_FTR_RADIX_KHRAP' undeclared (first use in this function); did you mean 'CPU_FTR_CAN_NAP'?
if (mmu_has_feature(MMU_FTR_RADIX_KHRAP)) {
^~~~~~~~~~~~~~~~~~~
CPU_FTR_CAN_NAP
cc1: some warnings being treated as errors
--
In file included from include/linux/uaccess.h:14:0,
from arch/powerpc/kernel/module.c:25:
arch/powerpc/include/asm/uaccess.h: In function 'unlock_user_access':
>> arch/powerpc/include/asm/uaccess.h:69:6: error: implicit declaration of function 'mmu_has_feature'; did you mean 'firmware_has_feature'? [-Werror=implicit-function-declaration]
if (mmu_has_feature(MMU_FTR_RADIX_KHRAP)) {
^~~~~~~~~~~~~~~
firmware_has_feature
>> arch/powerpc/include/asm/uaccess.h:69:22: error: 'MMU_FTR_RADIX_KHRAP' undeclared (first use in this function); did you mean 'CPU_FTR_CAN_NAP'?
if (mmu_has_feature(MMU_FTR_RADIX_KHRAP)) {
^~~~~~~~~~~~~~~~~~~
CPU_FTR_CAN_NAP
arch/powerpc/include/asm/uaccess.h:69:22: note: each undeclared identifier is reported only once for each function it appears in
arch/powerpc/include/asm/uaccess.h: In function 'lock_user_access':
arch/powerpc/include/asm/uaccess.h:83:22: error: 'MMU_FTR_RADIX_KHRAP' undeclared (first use in this function); did you mean 'CPU_FTR_CAN_NAP'?
if (mmu_has_feature(MMU_FTR_RADIX_KHRAP)) {
^~~~~~~~~~~~~~~~~~~
CPU_FTR_CAN_NAP
cc1: all warnings being treated as errors
vim +69 arch/powerpc/include/asm/uaccess.h
64
65 static inline unsigned long unlock_user_access(void)
66 {
67 unsigned long amr;
68
> 69 if (mmu_has_feature(MMU_FTR_RADIX_KHRAP)) {
70 amr = mfspr(SPRN_AMR);
71
72 isync();
73 mtspr(SPRN_AMR, 0);
74 isync();
75 return amr;
76 }
77
78 return 0;
79 }
80
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 15031 bytes --]
next prev parent reply other threads:[~2018-10-17 10:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 6:44 [PATCH 1/5] powerpc/64s: Kernel Hypervisor Restricted Access Prevention Russell Currey
2018-10-17 6:44 ` [PATCH 2/5] powerpc/futex: KHRAP support for futex ops Russell Currey
2018-10-17 6:44 ` [PATCH 3/5] powerpc/lib: checksum KHRAP support Russell Currey
2018-10-17 6:44 ` [PATCH 4/5] powerpc/64s: Disable KHRAP with nosmap option Russell Currey
2018-10-17 6:44 ` [PATCH 5/5] powerpc/64s: Document that PPC supports nosmap Russell Currey
2018-10-17 10:07 ` kbuild test robot [this message]
2018-10-17 11:30 ` [PATCH 1/5] powerpc/64s: Kernel Hypervisor Restricted Access Prevention Michael Ellerman
2018-10-18 2:03 ` Russell Currey
2018-10-17 12:59 ` Nicholas Piggin
2018-10-18 2:02 ` Russell Currey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201810171821.TOPFrPj5%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@01.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=ruscur@russell.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).