From: Oliver O'Halloran <oohall@gmail.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: Oliver O'Halloran <oohall@gmail.com>
Subject: [PATCH 3/7] powerpc/eeh_cache: Add a way to dump the EEH address cache
Date: Fri, 8 Feb 2019 14:07:58 +1100 [thread overview]
Message-ID: <20190208030802.10805-3-oohall@gmail.com> (raw)
In-Reply-To: <20190208030802.10805-1-oohall@gmail.com>
Adds a debugfs file that can be read to view the contents of the EEH
address cache. This is pretty similar to the existing
eeh_addr_cache_print() function, but that function is intended to debug
issues inside of the kernel since it's #ifdef`ed out by default, and writes
into the kernel log.
Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
---
arch/powerpc/include/asm/eeh.h | 3 +++
arch/powerpc/kernel/eeh.c | 2 +-
arch/powerpc/kernel/eeh_cache.c | 34 +++++++++++++++++++++++++++++----
3 files changed, 34 insertions(+), 5 deletions(-)
diff --git a/arch/powerpc/include/asm/eeh.h b/arch/powerpc/include/asm/eeh.h
index c003628441cc..fc21b6e78e91 100644
--- a/arch/powerpc/include/asm/eeh.h
+++ b/arch/powerpc/include/asm/eeh.h
@@ -460,6 +460,9 @@ static inline void eeh_readsl(const volatile void __iomem *addr, void * buf,
eeh_check_failure(addr);
}
+
+void eeh_cache_debugfs_init(void);
+
#endif /* CONFIG_PPC64 */
#endif /* __KERNEL__ */
#endif /* _POWERPC_EEH_H */
diff --git a/arch/powerpc/kernel/eeh.c b/arch/powerpc/kernel/eeh.c
index f6e65375a8de..d1f0bdf41fac 100644
--- a/arch/powerpc/kernel/eeh.c
+++ b/arch/powerpc/kernel/eeh.c
@@ -1810,7 +1810,7 @@ static int __init eeh_init_proc(void)
&eeh_enable_dbgfs_ops);
debugfs_create_u32("eeh_max_freezes", 0600,
powerpc_debugfs_root, &eeh_max_freezes);
-#endif
+ eeh_cache_debugfs_init();
}
return 0;
diff --git a/arch/powerpc/kernel/eeh_cache.c b/arch/powerpc/kernel/eeh_cache.c
index b2c320e0fcef..dba421a577e7 100644
--- a/arch/powerpc/kernel/eeh_cache.c
+++ b/arch/powerpc/kernel/eeh_cache.c
@@ -26,6 +26,7 @@
#include <linux/spinlock.h>
#include <linux/atomic.h>
#include <asm/pci-bridge.h>
+#include <asm/debugfs.h>
#include <asm/ppc-pci.h>
@@ -298,9 +299,34 @@ void eeh_addr_cache_build(void)
eeh_addr_cache_insert_dev(dev);
eeh_sysfs_add_device(dev);
}
+}
-#ifdef DEBUG
- /* Verify tree built up above, echo back the list of addrs. */
- eeh_addr_cache_print(&pci_io_addr_cache_root);
-#endif
+static int eeh_addr_cache_show(struct seq_file *s, void *v)
+{
+ struct rb_node *n = rb_first(&pci_io_addr_cache_root.rb_root);
+ struct pci_io_addr_range *piar;
+ int cnt = 0;
+
+ spin_lock(&pci_io_addr_cache_root.piar_lock);
+ while (n) {
+ piar = rb_entry(n, struct pci_io_addr_range, rb_node);
+
+ seq_printf(s, "%s addr range %3d [%pap-%pap]: %s\n",
+ (piar->flags & IORESOURCE_IO) ? "i/o" : "mem", cnt,
+ &piar->addr_lo, &piar->addr_hi, pci_name(piar->pcidev));
+
+ n = rb_next(n);
+ cnt++;
+ }
+ spin_unlock(&pci_io_addr_cache_root.piar_lock);
+
+ return 0;
+}
+DEFINE_SHOW_ATTRIBUTE(eeh_addr_cache);
+
+void eeh_cache_debugfs_init(void)
+{
+ debugfs_create_file_unsafe("eeh_address_cache", 0400,
+ powerpc_debugfs_root, NULL,
+ &eeh_addr_cache_fops);
}
--
2.20.1
next prev parent reply other threads:[~2019-02-08 3:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 3:07 [PATCH 1/7] powerpc/eeh: Use debugfs_create_u32 for eeh_max_freezes Oliver O'Halloran
2019-02-08 3:07 ` [PATCH 2/7] powerpc/eeh_cache: Add pr_debug() prints for insert/remove Oliver O'Halloran
2019-02-08 3:07 ` Oliver O'Halloran [this message]
2019-02-08 9:00 ` [PATCH 3/7] powerpc/eeh_cache: Add a way to dump the EEH address cache kbuild test robot
2019-02-08 9:47 ` Michael Ellerman
2019-02-08 13:14 ` Oliver
2019-02-11 2:16 ` Michael Ellerman
2019-02-08 3:07 ` [PATCH 4/7] powerpc/eeh_cache: Bump log level of eeh_addr_cache_print() Oliver O'Halloran
2019-02-08 3:08 ` [PATCH 5/7] powerpc/pci: Add pci_find_hose_for_domain() Oliver O'Halloran
2019-02-08 9:57 ` Michael Ellerman
2019-02-08 12:53 ` Oliver
2019-02-08 3:08 ` [PATCH 6/7] powerpc/eeh: Allow disabling recovery Oliver O'Halloran
2019-02-08 9:58 ` Michael Ellerman
2019-02-08 12:52 ` Oliver
2019-02-08 3:08 ` [PATCH 7/7] powerpc/eeh: Add eeh_force_recover to debugfs Oliver O'Halloran
2019-02-08 12:31 ` Michael Ellerman
2019-02-08 12:50 ` Oliver
2019-02-11 2:24 ` Michael Ellerman
2019-02-13 4:37 ` Sam Bobroff
2019-02-13 5:18 ` Oliver
2019-02-08 9:38 ` [PATCH 1/7] powerpc/eeh: Use debugfs_create_u32 for eeh_max_freezes Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190208030802.10805-3-oohall@gmail.com \
--to=oohall@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).