From: Greg KH <gregkh@linuxfoundation.org>
To: Andrew Donnellan <ajd@linux.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, stable@vger.kernel.org,
Stewart Smith <stewart@linux.ibm.com>,
Jordan Niethe <jniethe5@gmail.com>
Subject: Re: [PATCH v2] powerpc/powernv: Restrict OPAL symbol map to only be readable by root
Date: Fri, 3 May 2019 10:35:29 +0200 [thread overview]
Message-ID: <20190503083529.GA17715@kroah.com> (raw)
In-Reply-To: <f584ce91-a49b-ef33-7090-cb0a91b87e82@linux.ibm.com>
On Fri, May 03, 2019 at 06:27:18PM +1000, Andrew Donnellan wrote:
> On 3/5/19 5:59 pm, Greg KH wrote:>> -static BIN_ATTR_RO(symbol_map, 0);
> > > +static struct bin_attribute symbol_map_attr = {
> > > + .attr = {.name = "symbol_map", .mode = 0400},
> > > + .read = symbol_map_read
> > > +};
> >
> > There's no real need to rename the structure, right? Why not just keep
> > the bin_attr_symbol_map name? That would make this patch even smaller.
>
> No real need but it's locally more consistent with the rest of the PPC code.
> (Though perhaps the other cases should use the BIN_ATTR macro...)
>
> Given this is for stable I'm happy to change that if the smaller patch is
> more acceptable.
stable doesn't care, and if this is more consistent, that's fine with
me, I didn't see the larger picture here, just providing unsolicited
patch review :)
> > > static void opal_export_symmap(void)
> > > {
> > > @@ -698,10 +701,10 @@ static void opal_export_symmap(void)
> > > return;
> > > /* Setup attributes */
> > > - bin_attr_symbol_map.private = __va(be64_to_cpu(syms[0]));
> > > - bin_attr_symbol_map.size = be64_to_cpu(syms[1]);
> > > + symbol_map_attr.private = __va(be64_to_cpu(syms[0]));
> > > + symbol_map_attr.size = be64_to_cpu(syms[1]);
> > > - rc = sysfs_create_bin_file(opal_kobj, &bin_attr_symbol_map);
> > > + rc = sysfs_create_bin_file(opal_kobj, &symbol_map_attr);
> >
> > Meta-comment, odds are you are racing userspace when you create this
> > sysfs file, why not add it to the device's default attributes so the
> > driver core creates it for you at the correct time?
>
> I was not previously aware of default attributes...
>
> Are we actually racing against userspace in a subsys initcall?
You can be, if you subsys is a module :)
thanks,
greg k-h
next prev parent reply other threads:[~2019-05-03 8:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-03 7:52 [PATCH v2] powerpc/powernv: Restrict OPAL symbol map to only be readable by root Andrew Donnellan
2019-05-03 7:59 ` Greg KH
2019-05-03 8:27 ` Andrew Donnellan
2019-05-03 8:35 ` Greg KH [this message]
2019-05-03 8:50 ` Andrew Donnellan
2019-07-31 1:44 ` Andrew Donnellan
2019-07-31 11:43 ` Michael Ellerman
2019-08-10 10:20 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190503083529.GA17715@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ajd@linux.ibm.com \
--cc=jniethe5@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=stable@vger.kernel.org \
--cc=stewart@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).