From: Sven Schnelle <svens@stackframe.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linux-s390@vger.kernel.org, deller@gmx.de,
kexec@lists.infradead.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH RFC] generic ELF support for kexec
Date: Mon, 1 Jul 2019 19:08:53 +0200 [thread overview]
Message-ID: <20190701170853.GD19243@t470p.stackframe.org> (raw)
In-Reply-To: <87o92isbxg.fsf@concordia.ellerman.id.au>
Hi Michael,
On Fri, Jun 28, 2019 at 12:04:11PM +1000, Michael Ellerman wrote:
> Sven Schnelle <svens@stackframe.org> writes:
> https://github.com/linuxppc/wiki/wiki/Booting-with-Qemu
>
> But I'm not sure where you get a version of kexec that uses kexec_file().
kexec-tools HEAD supports it, so that's not a problem.
> > If that change is acceptable i would finish the patch and submit it. I think
> > best would be to push this change through Helge's parisc tree, so we don't
> > have any dependencies to sort out.
>
> That will work for you but could cause us problems if we have any
> changes that touch that code.
>
> It's easy enough to create a topic branch with just that patch that both
> of us merge.
What should be the base branch for that patch? Christophe suggested the
powerpc/merge branch?
> > #include <linux/elf.h>
> > #include <linux/kexec.h>
> > #include <linux/libfdt.h>
> > @@ -31,540 +29,6 @@
> > #include <linux/slab.h>
> > #include <linux/types.h>
> >
> > -#define PURGATORY_STACK_SIZE (16 * 1024)
>
> This is unused AFAICS. We should probably remove it explicitly rather
> than as part of this patch.
I have one patch right now. If wanted i can split up all the changes
suggested during the review into smaller pieces, whatever you prefer.
> Or that.
>
> > +#include <linux/slab.h>
> > +#include <linux/types.h>
> > +
> > +#define elf_addr_to_cpu elf64_to_cpu
>
> Why are we doing that rather than just using elf64_to_cpu directly?
>
> > +#ifndef Elf_Rel
> > +#define Elf_Rel Elf64_Rel
> > +#endif /* Elf_Rel */
>
> And that?
Don't know - ask the PPC people :-)
Regards
Sven
next prev parent reply other threads:[~2019-07-01 17:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 18:54 [PATCH RFC] generic ELF support for kexec Sven Schnelle
2019-06-26 16:09 ` Christophe Leroy
2019-06-28 2:04 ` Michael Ellerman
2019-07-01 17:08 ` Sven Schnelle [this message]
2019-07-01 12:31 ` Philipp Rudo
2019-07-01 18:11 ` Sven Schnelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190701170853.GD19243@t470p.stackframe.org \
--to=svens@stackframe.org \
--cc=deller@gmx.de \
--cc=kexec@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).