From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Xiaowei Bao <xiaowei.bao@nxp.com>
Cc: linux-arm-kernel@lists.infradead.org, roy.zang@nxp.com,
leonard.crestez@nxp.com, hayashi.kunihiko@socionext.com,
andrew.smirnov@gmail.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, yue.wang@amlogic.com,
kishon@ti.com, minghuan.Lian@nxp.com, dwmw@amazon.co.uk,
jonnyc@amazon.com, bhelgaas@google.com, tpiepho@impinj.com,
linuxppc-dev@lists.ozlabs.org, mingkai.hu@nxp.com,
l.stach@pengutronix.de
Subject: Re: [PATCHv5 1/2] PCI: layerscape: Add the bar_fixed_64bit property in EP driver.
Date: Tue, 13 Aug 2019 11:04:09 +0100 [thread overview]
Message-ID: <20190813100409.GB10070@red-moon> (raw)
In-Reply-To: <20190813062840.2733-1-xiaowei.bao@nxp.com>
git log --oneline --follow drivers/pci/controller/dwc/pci-layerscape.c
Do you see any commit with a $SUBJECT ending with a period ?
There is not. So remove it from yours too.
On Tue, Aug 13, 2019 at 02:28:39PM +0800, Xiaowei Bao wrote:
> The PCIe controller of layerscape just have 4 BARs, BAR0 and BAR1
> is 32bit, BAR2 and BAR4 is 64bit, this is determined by hardware,
> so set the bar_fixed_64bit with 0x14.
>
> Signed-off-by: Xiaowei Bao <xiaowei.bao@nxp.com>
> ---
> v2:
> - Replace value 0x14 with a macro.
> v3:
> - No change.
> v4:
> - send the patch again with '--to'.
> v5:
> - fix the commit message.
>
> drivers/pci/controller/dwc/pci-layerscape-ep.c | 1 +
> 1 file changed, 1 insertion(+)
scripts/get_maintainer.pl -f drivers/pci/controller/dwc/pci-layerscape-ep.c
Now, with the output you get justify all the people you send this email
to.
So, again, trim the CC list and it is the last time I tell you.
Before sending patches on mailing lists use git --dry-run to check
the emails you are sending.
Thanks,
Lorenzo
> diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c
> index be61d96..ca9aa45 100644
> --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c
> +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c
> @@ -44,6 +44,7 @@ static const struct pci_epc_features ls_pcie_epc_features = {
> .linkup_notifier = false,
> .msi_capable = true,
> .msix_capable = false,
> + .bar_fixed_64bit = (1 << BAR_2) | (1 << BAR_4),
> };
>
> static const struct pci_epc_features*
> --
> 2.9.5
>
next prev parent reply other threads:[~2019-08-13 10:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 6:28 [PATCHv5 1/2] PCI: layerscape: Add the bar_fixed_64bit property in EP driver Xiaowei Bao
2019-08-13 6:28 ` [PATCHv5 2/2] PCI: layerscape: Add CONFIG_PCI_LAYERSCAPE_EP to build EP/RC separately Xiaowei Bao
2019-08-13 7:30 ` [PATCHv5 1/2] PCI: layerscape: Add the bar_fixed_64bit property in EP driver Kishon Vijay Abraham I
2019-08-13 7:39 ` [EXT] " Xiaowei Bao
2019-08-13 9:51 ` Lorenzo Pieralisi
2019-08-13 10:04 ` Lorenzo Pieralisi [this message]
2019-08-13 11:02 ` Xiaowei Bao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190813100409.GB10070@red-moon \
--to=lorenzo.pieralisi@arm.com \
--cc=andrew.smirnov@gmail.com \
--cc=bhelgaas@google.com \
--cc=dwmw@amazon.co.uk \
--cc=hayashi.kunihiko@socionext.com \
--cc=jonnyc@amazon.com \
--cc=kishon@ti.com \
--cc=l.stach@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=minghuan.Lian@nxp.com \
--cc=mingkai.hu@nxp.com \
--cc=roy.zang@nxp.com \
--cc=tpiepho@impinj.com \
--cc=xiaowei.bao@nxp.com \
--cc=yue.wang@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).