From: peterz@infradead.org
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: linux-arch@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, Nicholas Piggin <npiggin@gmail.com>,
Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>
Subject: Re: [PATCH 1/2] lockdep: improve current->(hard|soft)irqs_enabled synchronisation with actual irq state
Date: Wed, 19 Aug 2020 17:32:50 +0200 [thread overview]
Message-ID: <20200819153250.GF2674@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <7fadb5ab-9869-396d-ff5d-c0adb6fc0b35@ozlabs.ru>
On Wed, Aug 19, 2020 at 08:39:13PM +1000, Alexey Kardashevskiy wrote:
> > or current upstream?
>
> The upstream 18445bf405cb (13 hours old) also shows the problem. Yours
> 1/2 still fixes it.
Afaict that just reduces the window.
Isn't the problem that:
arch/powerpc/kernel/exceptions-64e.S
START_EXCEPTION(perfmon);
NORMAL_EXCEPTION_PROLOG(0x260, BOOKE_INTERRUPT_PERFORMANCE_MONITOR,
PROLOG_ADDITION_NONE)
EXCEPTION_COMMON(0x260)
INTS_DISABLE
# RECONCILE_IRQ_STATE
# TRACE_DISABLE_INTS
# TRACE_WITH_FRAME_BUFFER(trace_hardirqs_off)
#
# but we haven't done nmi_enter() yet... whoopsy
CHECK_NAPPING()
addi r3,r1,STACK_FRAME_OVERHEAD
bl performance_monitor_exception
# perf_irq()
# perf_event_interrupt
# __perf_event_interrupt
# nmi_enter()
That is, afaict your entry code is buggered.
next prev parent reply other threads:[~2020-08-19 15:38 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 10:56 [PATCH 1/2] lockdep: improve current->(hard|soft)irqs_enabled synchronisation with actual irq state Nicholas Piggin
2020-07-23 10:56 ` [PATCH 2/2] lockdep: warn on redundant or incorrect irq state changes Nicholas Piggin
2020-07-24 2:57 ` kernel test robot
2020-08-04 10:00 ` Alexey Kardashevskiy
2020-07-23 11:40 ` [PATCH 1/2] lockdep: improve current->(hard|soft)irqs_enabled synchronisation with actual irq state Peter Zijlstra
2020-07-23 13:11 ` Nicholas Piggin
2020-07-23 14:59 ` Peter Zijlstra
2020-07-23 16:20 ` Nicholas Piggin
2020-07-24 4:16 ` Alexey Kardashevskiy
2020-07-24 5:59 ` Nicholas Piggin
2020-07-26 7:40 ` Alexey Kardashevskiy
2020-07-24 6:16 ` Athira Rajeev
2020-07-24 2:19 ` kernel test robot
2020-07-24 3:15 ` kernel test robot
2020-07-25 20:26 ` Peter Zijlstra
2020-07-26 4:14 ` Nicholas Piggin
2020-07-26 11:59 ` peterz
2020-07-26 12:11 ` peterz
2020-07-28 11:22 ` Nicholas Piggin
2020-08-07 11:11 ` peterz
2020-08-12 8:18 ` Nicholas Piggin
2020-08-12 10:35 ` peterz
2020-08-18 7:22 ` Nicholas Piggin
2020-08-18 15:41 ` peterz
2020-08-18 23:54 ` Nicholas Piggin
2020-08-19 10:39 ` Alexey Kardashevskiy
2020-08-19 15:32 ` peterz [this message]
2020-08-19 15:39 ` peterz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200819153250.GF2674@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=aik@ozlabs.ru \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=npiggin@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).