Re: [PATCH 18/20] arch: dts: Fix EHCI/OHCI DT nodes name

From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
To: Alexandre Torgue <alexandre.torgue@st.com>
Cc: "Neil Armstrong" <narmstrong@baylibre.com>,
	"Bjorn Andersson" <bjorn.andersson@linaro.org>,
	"Paul Cercueil" <paul@crapouillou.net>,
	"Paul Mackerras" <paulus@samba.org>,
	"Pavel Parkhomenko" <Pavel.Parkhomenko@baikalelectronics.ru>,
	linux-stm32@st-md-mailman.stormreply.com,
	"Rafał Miłecki" <zajec5@gmail.com>,
	"Alexey Brodkin" <abrodkin@synopsys.com>,
	"Wei Xu" <xuwei5@hisilicon.com>, "Andy Gross" <agross@kernel.org>,
	bcm-kernel-feedback-list@broadcom.com,
	"Kevin Hilman" <khilman@baylibre.com>,
	linux-snps-arc@lists.infradead.org, devicetree@vger.kernel.org,
	"Mathias Nyman" <mathias.nyman@intel.com>,
	"Hauke Mehrtens" <hauke@hauke-m.de>,
	"Lad Prabhakar" <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	"Vladimir Zapolskiy" <vz@mleia.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	linux-mediatek@lists.infradead.org,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"Alexey Malahov" <Alexey.Malahov@baikalelectronics.ru>,
	linux-arm-kernel@lists.infradead.org,
	"Roger Quadros" <rogerq@ti.com>,
	"Felipe Balbi" <balbi@kernel.org>,
	"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
	linux-usb@vger.kernel.org, linux-mips@vger.kernel.org,
	"Serge Semin" <fancer.lancer@gmail.com>,
	linux-kernel@vger.kernel.org,
	"Manu Gautam" <mgautam@codeaurora.org>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Vineet Gupta" <vgupta@synopsys.com>,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 18/20] arch: dts: Fix EHCI/OHCI DT nodes name
Date: Fri, 16 Oct 2020 11:52:35 +0300	[thread overview]
Message-ID: <20201016085235.znzzbqxac4yvh3cz@mobilestation> (raw)
In-Reply-To: <8a7af322-227b-9923-8fb6-f284af582b40@st.com>

Hello Alexandre,

On Fri, Oct 16, 2020 at 09:08:23AM +0200, Alexandre Torgue wrote:
> Hi Serge,
> 
> On 10/14/20 12:14 PM, Serge Semin wrote:
> > In accordance with the Generic EHCI/OHCI bindings the corresponding node
> > name is suppose to comply with the Generic USB HCD DT schema, which
> > requires the USB nodes to have the name acceptable by the regexp:
> > "^usb(@.*)?" . Let's fix the DTS files, which have the nodes defined with
> > incompatible names.
> > 
> > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> > 
> > ---
> > 
> > Please, test the patch out to make sure it doesn't brake the dependent DTS
> > files. I did only a manual grepping of the possible nodes dependencies.
> > ---
> >   arch/arc/boot/dts/axs10x_mb.dtsi               | 4 ++--
> >   arch/arc/boot/dts/hsdk.dts                     | 4 ++--
> >   arch/arc/boot/dts/vdk_axs10x_mb.dtsi           | 2 +-
> >   arch/arm/boot/dts/bcm5301x.dtsi                | 4 ++--
> >   arch/arm/boot/dts/bcm53573.dtsi                | 4 ++--
> >   arch/arm/boot/dts/hisi-x5hd2.dtsi              | 4 ++--
> >   arch/arm/boot/dts/lpc18xx.dtsi                 | 4 ++--
> >   arch/arm/boot/dts/stm32mp151.dtsi              | 4 ++--
> >   arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi | 4 ++--
> >   arch/arm64/boot/dts/hisilicon/hip06.dtsi       | 4 ++--
> >   arch/arm64/boot/dts/hisilicon/hip07.dtsi       | 4 ++--
> >   arch/mips/boot/dts/ingenic/jz4740.dtsi         | 2 +-
> >   arch/mips/boot/dts/ingenic/jz4770.dtsi         | 2 +-
> >   arch/mips/boot/dts/mti/sead3.dts               | 2 +-
> >   arch/mips/boot/dts/ralink/mt7628a.dtsi         | 2 +-
> >   arch/powerpc/boot/dts/akebono.dts              | 6 +++---
> >   16 files changed, 28 insertions(+), 28 deletions(-)
> > 
> 

> I surely missed something, but we have here in the same patch modifications
> for different architectures and different vendors.
> 
> Do you plan to split this patch after getting some Acked-by / Tested-by ?

Yeah, I'll split this patch and two next ones up in v3.

-Sergey

> 
> regards
> Alex
> 
> 