From: Segher Boessenkool <segher@kernel.crashing.org>
To: Bill Wendling <morbo@google.com>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v3 3/3] powerpc/64s: feature: Work around inline asm issues
Date: Mon, 23 Nov 2020 14:08:46 -0600 [thread overview]
Message-ID: <20201123200846.GJ2672@gate.crashing.org> (raw)
In-Reply-To: <CAGG=3QXR=Yfh8PNa4m-kQLTBP4YKD8OGm_6fSUgeasQ1ar9b2g@mail.gmail.com>
On Mon, Nov 23, 2020 at 12:01:01PM -0800, Bill Wendling wrote:
> On Mon, Nov 23, 2020 at 11:58 AM Segher Boessenkool
> <segher@kernel.crashing.org> wrote:
> > > On Sun, Nov 22, 2020 at 10:36 PM Segher Boessenkool
> > > <segher@kernel.crashing.org> wrote:
> > > > "true" (as a result of a comparison) in as is -1, not 1.
> >
> > On Mon, Nov 23, 2020 at 11:43:11AM -0800, Bill Wendling wrote:
> > > What Segher said. :-) Also, if you reverse the comparison, you'll get
> > > a build error.
> >
> > But that means your patch is the wrong way around?
> >
> > - .ifgt (label##4b- label##3b)-(label##2b- label##1b); \
> > - .error "Feature section else case larger than body"; \
> > - .endif; \
> > + .org . - ((label##4b-label##3b) > (label##2b-label##1b)); \
> >
> > It should be a + in that last line, not a -.
>
> I said so in a follow up email.
Yeah, and that arrived a second after I pressed "send" :-)
> > Was this tested?
> >
> Please don't be insulting. Anyone can make an error.
Absolutely, but it is just a question. It seems you could improve that
testing! It helps you yourself most of all ;-)
Segher
next prev parent reply other threads:[~2020-11-23 20:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-17 0:47 [PATCH 0/2] Fixes for clang/lld Bill Wendling
2020-10-17 0:47 ` [PATCH 1/2] powerpc/wrapper: Add "-z notext" flag to disable diagnostic Bill Wendling
2020-10-17 0:47 ` [PATCH 2/2] powerpc/boot: Use clang when CC is clang Bill Wendling
2020-11-18 22:35 ` [PATCH 0/3] PPC: fixes for clang support Bill Wendling
2020-11-20 22:40 ` [PATCH v3 " Bill Wendling
2020-11-20 22:40 ` [PATCH 1/3] powerpc/wrapper: add "-z notext" flag to disable diagnostic Bill Wendling
2020-11-20 22:40 ` [PATCH v3 2/3] powerpc/boot: Use clang when CC is clang Bill Wendling
2020-11-20 22:40 ` [PATCH v3 3/3] powerpc/64s: feature: Work around inline asm issues Bill Wendling
2020-11-23 5:44 ` Michael Ellerman
2020-11-23 6:34 ` Segher Boessenkool
2020-11-23 19:43 ` Bill Wendling
2020-11-23 19:53 ` Bill Wendling
2020-11-23 19:56 ` Segher Boessenkool
2020-11-23 20:01 ` Bill Wendling
2020-11-23 20:08 ` Segher Boessenkool [this message]
2020-11-23 20:17 ` Bill Wendling
2020-11-24 3:43 ` Michael Ellerman
2020-11-25 5:13 ` Bill Wendling
2020-11-27 1:03 ` Michael Ellerman
2020-11-27 1:10 ` Bill Wendling
2020-11-27 1:59 ` Bill Wendling
2020-11-18 22:35 ` [PATCH 1/3] powerpc/wrapper: add "-z notext" flag to disable diagnostic Bill Wendling
2020-11-18 22:35 ` [PATCH 2/3] powerpc/boot: Use clang when CC is clang Bill Wendling
2020-11-18 22:35 ` [PATCH 3/3] powerpc/64s: feature: work around inline asm issues Bill Wendling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201123200846.GJ2672@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=morbo@google.com \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).