From: Jianlin Lv <Jianlin.Lv@arm.com>
To: bpf@vger.kernel.org
Cc: irogers@google.com, songliubraving@fb.com,
catalin.marinas@arm.com, linux-doc@vger.kernel.org,
zlim.lnx@gmail.com, paul.walmsley@sifive.com, ast@kernel.org,
andrii@kernel.org, paulus@samba.org, sandipan@linux.ibm.com,
hpa@zytor.com, sparclinux@vger.kernel.org,
illusionist.neo@gmail.com, maheshb@google.com, will@kernel.org,
nicolas.dichtel@6wind.com, linux-s390@vger.kernel.org,
iii@linux.ibm.com, paulburton@kernel.org, corbet@lwn.net,
mchehab+huawei@kernel.org, masahiroy@kernel.org, x86@kernel.org,
john.fastabend@gmail.com, linux@armlinux.org.uk,
linux-riscv@lists.infradead.org, borntraeger@de.ibm.com,
mingo@redhat.com, linux-arm-kernel@lists.infradead.org,
naveen.n.rao@linux.ibm.com, kuba@kernel.org, tklauser@distanz.ch,
linux-mips@vger.kernel.org, grantseltzer@gmail.com,
xi.wang@gmail.com, aou@eecs.berkeley.edu, keescook@chromium.org,
gor@linux.ibm.com, luke.r.nels@gmail.com,
linux-kernel@vger.kernel.org, hca@linux.ibm.com,
kpsingh@kernel.org, iecedge@gmail.com, horms@verge.net.au,
bp@alien8.de, viro@zeniv.linux.org.uk, yhs@fb.com,
Jianlin.Lv@arm.com, tglx@linutronix.de, dvyukov@google.com,
tsbogend@alpha.franken.de, daniel@iogearbox.net,
yoshfuji@linux-ipv6.org, netdev@vger.kernel.org,
dsahern@kernel.org, udknight@gmail.com, kafai@fb.com,
bjorn@kernel.org, palmer@dabbelt.com, quentin@isovalent.com,
linuxppc-dev@lists.ozlabs.org, davem@davemloft.net
Subject: [PATCH bpf-next 2/2] docs: bpf: bpf_jit_enable mode changed
Date: Thu, 15 Apr 2021 17:32:50 +0800 [thread overview]
Message-ID: <20210415093250.3391257-2-Jianlin.Lv@arm.com> (raw)
In-Reply-To: <20210415093250.3391257-1-Jianlin.Lv@arm.com>
Remove information about bpf_jit_enable=2 mode and added description for
how to use the bpf_jit_disasm tool after get rid of =2 mode.
Signed-off-by: Jianlin Lv <Jianlin.Lv@arm.com>
---
Documentation/admin-guide/sysctl/net.rst | 1 -
Documentation/networking/filter.rst | 25 ++++++------------------
2 files changed, 6 insertions(+), 20 deletions(-)
diff --git a/Documentation/admin-guide/sysctl/net.rst b/Documentation/admin-guide/sysctl/net.rst
index c941b214e0b7..a39f99deac38 100644
--- a/Documentation/admin-guide/sysctl/net.rst
+++ b/Documentation/admin-guide/sysctl/net.rst
@@ -86,7 +86,6 @@ Values:
- 0 - disable the JIT (default value)
- 1 - enable the JIT
- - 2 - enable the JIT and ask the compiler to emit traces on kernel log.
bpf_jit_harden
--------------
diff --git a/Documentation/networking/filter.rst b/Documentation/networking/filter.rst
index 251c6bd73d15..86954f922168 100644
--- a/Documentation/networking/filter.rst
+++ b/Documentation/networking/filter.rst
@@ -504,25 +504,12 @@ been previously enabled by root::
echo 1 > /proc/sys/net/core/bpf_jit_enable
-For JIT developers, doing audits etc, each compile run can output the generated
-opcode image into the kernel log via::
-
- echo 2 > /proc/sys/net/core/bpf_jit_enable
-
-Example output from dmesg::
-
- [ 3389.935842] flen=6 proglen=70 pass=3 image=ffffffffa0069c8f
- [ 3389.935847] JIT code: 00000000: 55 48 89 e5 48 83 ec 60 48 89 5d f8 44 8b 4f 68
- [ 3389.935849] JIT code: 00000010: 44 2b 4f 6c 4c 8b 87 d8 00 00 00 be 0c 00 00 00
- [ 3389.935850] JIT code: 00000020: e8 1d 94 ff e0 3d 00 08 00 00 75 16 be 17 00 00
- [ 3389.935851] JIT code: 00000030: 00 e8 28 94 ff e0 83 f8 01 75 07 b8 ff ff 00 00
- [ 3389.935852] JIT code: 00000040: eb 02 31 c0 c9 c3
-
-When CONFIG_BPF_JIT_ALWAYS_ON is enabled, bpf_jit_enable is permanently set to 1 and
-setting any other value than that will return in failure. This is even the case for
-setting bpf_jit_enable to 2, since dumping the final JIT image into the kernel log
-is discouraged and introspection through bpftool (under tools/bpf/bpftool/) is the
-generally recommended approach instead.
+When CONFIG_BPF_JIT_ALWAYS_ON is enabled, bpf_jit_enable is permanently set
+to 1 and setting any other value than that will return in failure.
+For debugging JITs, the introspection through bpftool (tools/bpf/bpftool/)
+is the generally recommended approach instead. For JIT developers, doing
+audits etc, you can insert bpf_jit_dump() and recompile the kernel to
+output the generated opcode image into the kernel log.
In the kernel source tree under tools/bpf/, there's bpf_jit_disasm for
generating disassembly out of the kernel log's hexdump::
--
2.25.1
next prev parent reply other threads:[~2021-04-15 10:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 9:32 [PATCH bpf-next 1/2] bpf: Remove bpf_jit_enable=2 debugging mode Jianlin Lv
2021-04-15 9:32 ` Jianlin Lv [this message]
2021-04-15 14:37 ` Daniel Borkmann
2021-04-15 15:41 ` Quentin Monnet
2021-04-15 23:49 ` Alexei Starovoitov
2021-04-17 8:16 ` Christophe Leroy
2021-04-20 3:28 ` Alexei Starovoitov
2021-04-21 13:10 ` Christophe Leroy
2021-04-21 15:27 ` Quentin Monnet
2021-04-21 16:29 ` John Fastabend
2021-04-23 7:19 ` Christophe Leroy
2021-04-23 10:26 ` Quentin Monnet
2021-04-23 10:46 ` Christophe Leroy
2021-04-23 10:59 ` Quentin Monnet
2021-04-23 11:29 ` Christophe Leroy
2021-05-14 6:34 ` Christophe Leroy
2021-04-16 13:38 ` Jianlin Lv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210415093250.3391257-2-Jianlin.Lv@arm.com \
--to=jianlin.lv@arm.com \
--cc=andrii@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=borntraeger@de.ibm.com \
--cc=bp@alien8.de \
--cc=bpf@vger.kernel.org \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=dvyukov@google.com \
--cc=gor@linux.ibm.com \
--cc=grantseltzer@gmail.com \
--cc=hca@linux.ibm.com \
--cc=horms@verge.net.au \
--cc=hpa@zytor.com \
--cc=iecedge@gmail.com \
--cc=iii@linux.ibm.com \
--cc=illusionist.neo@gmail.com \
--cc=irogers@google.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=keescook@chromium.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=luke.r.nels@gmail.com \
--cc=maheshb@google.com \
--cc=masahiroy@kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=mingo@redhat.com \
--cc=naveen.n.rao@linux.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=paulburton@kernel.org \
--cc=paulus@samba.org \
--cc=quentin@isovalent.com \
--cc=sandipan@linux.ibm.com \
--cc=songliubraving@fb.com \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tklauser@distanz.ch \
--cc=tsbogend@alpha.franken.de \
--cc=udknight@gmail.com \
--cc=viro@zeniv.linux.org.uk \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=xi.wang@gmail.com \
--cc=yhs@fb.com \
--cc=yoshfuji@linux-ipv6.org \
--cc=zlim.lnx@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).