From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Mohan Kumar <mohankumar718@gmail.com>
Cc: daniel.lezcano@linaro.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH] drivers: cpuidle: This patch fix the following checkpatch warning.
Date: Thu, 18 Apr 2019 15:57:00 +0200 [thread overview]
Message-ID: <4392665.MNVv1Oa0lS@kreacher> (raw)
In-Reply-To: <1555512754-6450-1-git-send-email-mohankumar718@gmail.com>
On Wednesday, April 17, 2019 4:52:34 PM CEST Mohan Kumar wrote:
> Use pr_debug instead of printk
>
> WARNING: Prefer [subsystem eg: netdev]_dbg([subsystem]dev, ... then
> dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG ...
>
> Signed-off-by: Mohan Kumar <mohankumar718@gmail.com>
> ---
> drivers/cpuidle/cpuidle-powernv.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpuidle/cpuidle-powernv.c b/drivers/cpuidle/cpuidle-powernv.c
> index 84b1ebe..7cf9835 100644
> --- a/drivers/cpuidle/cpuidle-powernv.c
> +++ b/drivers/cpuidle/cpuidle-powernv.c
> @@ -401,7 +401,7 @@ static int __init powernv_processor_idle_init(void)
> powernv_cpuidle_driver_init();
> retval = cpuidle_register(&powernv_idle_driver, NULL);
> if (retval) {
> - printk(KERN_DEBUG "Registration of powernv driver failed.\n");
> + pr_debug("Registration of powernv driver failed.\n");
> return retval;
> }
>
> @@ -413,7 +413,7 @@ static int __init powernv_processor_idle_init(void)
> "cpuidle/powernv:dead", NULL,
> powernv_cpuidle_cpu_dead);
> WARN_ON(retval < 0);
> - printk(KERN_DEBUG "powernv_idle_driver registered\n");
> + pr_debug("powernv_idle_driver registered\n");
> return 0;
> }
>
>
Recently, you've sent two different patches against two different drivers with the same subject.
IMO it is fair enough to call that "confusing".
Moreover, pr_debug() is not a direct replacement for printk(KERN_DEBUG ) as the latter does
not require dynamic debug to be enabled and I'm not really sure if you are aware of that
difference.
next prev parent reply other threads:[~2019-04-18 14:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 14:52 [PATCH] drivers: cpuidle: This patch fix the following checkpatch warning Mohan Kumar
2019-04-18 13:57 ` Rafael J. Wysocki [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-04-17 7:06 Mohan Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4392665.MNVv1Oa0lS@kreacher \
--to=rjw@rjwysocki.net \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mohankumar718@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).