From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Geoff Levand <geoff@infradead.org>, linuxppc-dev@lists.ozlabs.org
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Paul Mackerras <paulus@samba.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init()
Date: Mon, 7 Aug 2017 21:04:37 +0200 [thread overview]
Message-ID: <57b472a0-0245-f821-cea8-171c34cc9df7@users.sourceforge.net> (raw)
In-Reply-To: <3a657b44-2bc8-ee05-3a42-db7af354967e@infradead.org>
>>> I didn't consider one would be triggered by the kzalloc failure.
>>
>> Do you reconsider any special system settings for further
>> software evolution then?
>
> Sorry, I don't quite understand your question.
Do you try to configure the Linux error reporting to any special needs?
> I think your original patch is OK,
How does this feedback fit to the initial response “Not Applicable”?
https://patchwork.ozlabs.org/patch/798575/
> and I would appreciate if you added a check for failure of ps3vram_cache_init()
> in ps3vram_probe().
I unsure if this adjustment will need more software updates.
> If you decide not to add that check I'll create a patch for it later.
I am curious on who will pick this update candidate up as the next improvement.
Have you got any preferences for the exception handling there?
Regards,
Markus
next prev parent reply other threads:[~2017-08-07 19:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 10:52 [PATCH] block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init() SF Markus Elfring
2017-08-07 15:10 ` Geoff Levand
2017-08-07 15:13 ` Joe Perches
2017-08-07 16:27 ` SF Markus Elfring
2017-08-07 18:28 ` Geoff Levand
2017-08-07 18:34 ` SF Markus Elfring
2017-08-07 18:49 ` Geoff Levand
2017-08-07 19:04 ` SF Markus Elfring [this message]
2017-08-07 20:17 ` Geoff Levand
2017-08-08 8:23 ` SF Markus Elfring
2017-08-08 2:13 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57b472a0-0245-f821-cea8-171c34cc9df7@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=benh@kernel.crashing.org \
--cc=geoff@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).