From: Russell Currey <ruscur@russell.cc>
To: Christophe Leroy <christophe.leroy@c-s.fr>,
linuxppc-dev@lists.ozlabs.org
Cc: Julia.Lawall@lip6.fr, rashmica.g@gmail.com
Subject: Re: [PATCH 2/2] powerpc/mm: Warn if W+X pages found on boot
Date: Thu, 02 May 2019 15:51:15 +1000 [thread overview]
Message-ID: <6f3c93698669da36cb6bb354394a1f63c93a58cc.camel@russell.cc> (raw)
In-Reply-To: <673532fb-cd09-748f-e936-14c0cab854b1@c-s.fr>
> > > > + if (radix_enabled())
> > > > + st.start_address = PAGE_OFFSET;
> > > > + else
> > > + st.start_address = KERN_VIRT_START;
> > >
> > > KERN_VIRT_START doesn't exist on PPC32.
> > >
> > > Christophe
> > >
> > Thanks a lot for the review! Applied all your suggestions. What
> > should I use on PPC32 instead?
>
> Indeed it looks like KERN_VIRT_START is defined as 0 for PPC32 at
> the
> top of ptdump.c, which look strange to me.
>
> I guess PAGE_OFFSET should be the good value for KERN_VIRT_START on
> PPC32.
>
> Christophe
git blame says you put it there :) I'll set it to PAGE_OFFSET instead
of zero. Cheers
- Russell
next prev parent reply other threads:[~2019-05-02 5:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 6:39 [PATCH 1/2] powerpc/mm/ptdump: Wrap seq_printf() to handle NULL pointers Russell Currey
2019-04-24 6:39 ` [PATCH 2/2] powerpc/mm: Warn if W+X pages found on boot Russell Currey
2019-04-24 7:14 ` Christophe Leroy
2019-05-01 7:04 ` Russell Currey
2019-05-02 5:23 ` Christophe Leroy
2019-05-02 5:51 ` Russell Currey [this message]
2019-08-09 13:11 ` Christophe Leroy
2019-04-24 6:56 ` [PATCH 1/2] powerpc/mm/ptdump: Wrap seq_printf() to handle NULL pointers Christophe Leroy
2019-04-24 7:00 ` Russell Currey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f3c93698669da36cb6bb354394a1f63c93a58cc.camel@russell.cc \
--to=ruscur@russell.cc \
--cc=Julia.Lawall@lip6.fr \
--cc=christophe.leroy@c-s.fr \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=rashmica.g@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).