From: Michael Ellerman <mpe@ellerman.id.au>
To: Ganesh <ganeshgr@linux.ibm.com>, linuxppc-dev@lists.ozlabs.org
Cc: mahesh@linux.vnet.ibm.com, npiggin@gmail.com, aneesh.kumar@linux.ibm.com
Subject: Re: [PATCH v4] powerpc/pseries: Avoid using addr_to_pfn in real mode
Date: Thu, 22 Oct 2020 14:50:22 +1100 [thread overview]
Message-ID: <87imb2yl4x.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <566dfec7-4574-b518-f55b-5d34ca3bed08@linux.ibm.com>
Ganesh <ganeshgr@linux.ibm.com> writes:
> On 7/24/20 12:09 PM, Ganesh Goudar wrote:
>
>> When an UE or memory error exception is encountered the MCE handler
>> tries to find the pfn using addr_to_pfn() which takes effective
>> address as an argument, later pfn is used to poison the page where
>> memory error occurred, recent rework in this area made addr_to_pfn
>> to run in real mode, which can be fatal as it may try to access
>> memory outside RMO region.
>>
>> Have two helper functions to separate things to be done in real mode
>> and virtual mode without changing any functionality. This also fixes
>> the following error as the use of addr_to_pfn is now moved to virtual
>> mode.
>>
>> Without this change following kernel crash is seen on hitting UE.
...
>>
>
> We need this fix as well to fix pseries mce handling, Any comments on this patch.
Looks OK. I'll pick it up.
cheers
next prev parent reply other threads:[~2020-10-22 3:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 6:39 [PATCH v4] powerpc/pseries: Avoid using addr_to_pfn in real mode Ganesh Goudar
2020-10-20 11:33 ` Ganesh
2020-10-22 3:50 ` Michael Ellerman [this message]
2020-10-24 10:27 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imb2yl4x.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=aneesh.kumar@linux.ibm.com \
--cc=ganeshgr@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.vnet.ibm.com \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).