From: Juliet Kim <julietk@linux.vnet.ibm.com>
To: Michal Suchanek <msuchanek@suse.de>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org,
Thomas Falcon <tlfalcon@linux.ibm.com>,
Paul Mackerras <paulus@samba.org>,
John Allen <jallen@linux.ibm.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] net/ibmvnic: Fix missing { in __ibmvnic_reset
Date: Mon, 9 Sep 2019 17:49:12 -0500 [thread overview]
Message-ID: <953ee49d-5d2f-90d2-bc6f-b738c0718c6f@linux.vnet.ibm.com> (raw)
In-Reply-To: <20190909204451.7929-1-msuchanek@suse.de>
On 9/9/19 3:44 PM, Michal Suchanek wrote:
> Commit 1c2977c09499 ("net/ibmvnic: free reset work of removed device from queue")
> adds a } without corresponding { causing build break.
>
> Fixes: 1c2977c09499 ("net/ibmvnic: free reset work of removed device from queue")
> Signed-off-by: Michal Suchanek <msuchanek@suse.de>
Reviewed-by: Juliet Kim <julietk@linux.vnet.ibm.com>
> ---
> drivers/net/ethernet/ibm/ibmvnic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
> index 6644cabc8e75..5cb55ea671e3 100644
> --- a/drivers/net/ethernet/ibm/ibmvnic.c
> +++ b/drivers/net/ethernet/ibm/ibmvnic.c
> @@ -1984,7 +1984,7 @@ static void __ibmvnic_reset(struct work_struct *work)
> rwi = get_next_rwi(adapter);
> while (rwi) {
> if (adapter->state == VNIC_REMOVING ||
> - adapter->state == VNIC_REMOVED)
> + adapter->state == VNIC_REMOVED) {
> kfree(rwi);
> rc = EBUSY;
> break;
next prev parent reply other threads:[~2019-09-09 22:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 21:30 [PATCH] net/ibmvnic: free reset work of removed device from queue Juliet Kim
2019-09-07 4:24 ` kbuild test robot
2019-09-07 15:37 ` David Miller
2019-09-09 20:44 ` [PATCH] net/ibmvnic: Fix missing { in __ibmvnic_reset Michal Suchanek
2019-09-09 21:21 ` Tyrel Datwyler
2019-09-09 22:49 ` Juliet Kim [this message]
2019-09-10 7:45 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=953ee49d-5d2f-90d2-bc6f-b738c0718c6f@linux.vnet.ibm.com \
--to=julietk@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=jallen@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=msuchanek@suse.de \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=tlfalcon@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).