linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: Christoph Hellwig <hch@lst.de>,
	"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
	"axboe@kernel.dk" <axboe@kernel.dk>
Cc: "dan.j.williams@intel.com" <dan.j.williams@intel.com>,
	"hskinnemoen@gmail.com" <hskinnemoen@gmail.com>,
	"egtvedt@samfundet.no" <egtvedt@samfundet.no>,
	"realmz6@gmail.com" <realmz6@gmail.com>,
	"dhowells@redhat.com" <dhowells@redhat.com>,
	"monstr@monstr.eu" <monstr@monstr.eu>,
	"x86@kernel.org" <x86@kernel.org>,
	"dwmw2@infradead.org" <dwmw2@infradead.org>,
	"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
	"grundler@parisc-linux.org" <grundler@parisc-linux.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
	"linux-alpha@vger.kernel.org" <linux-alpha@vger.kernel.org>,
	"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
	"linux-metag@vger.kernel.org" <linux-metag@vger.kernel.org>,
	"linux-mips@linux-mips.org" <linux-mips@linux-mips.org>,
	"linux-parisc@vger.kernel.org" <linux-parisc@vger.kernel.org>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
	"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
	"sparclinux@vger.kernel.org" <sparclinux@vger.kernel.org>,
	"linux-xtensa@linux-xtensa.org" <linux-xtensa@linux-xtensa.org>,
	"linux-nvdimm@ml01.01.org" <linux-nvdimm@ml01.01.org>,
	"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: [PATCH 19/31] arc: handle page-less SG entries
Date: Wed, 12 Aug 2015 10:28:55 +0000	[thread overview]
Message-ID: <C2D7FE5348E1B147BCA15975FBA23075665B21F5@IN01WEMBXB.internal.synopsys.com> (raw)
In-Reply-To: 1439363150-8661-20-git-send-email-hch@lst.de

On Wednesday 12 August 2015 12:39 PM, Christoph Hellwig wrote:=0A=
> Make all cache invalidation conditional on sg_has_page() and use=0A=
> sg_phys to get the physical address directly.=0A=
>=0A=
> Signed-off-by: Christoph Hellwig <hch@lst.de>=0A=
=0A=
With a minor nit below.=0A=
=0A=
Acked-by: Vineet Gupta <vgupta@synopsys.com>=0A=
=0A=
> ---=0A=
>  arch/arc/include/asm/dma-mapping.h | 26 +++++++++++++++++++-------=0A=
>  1 file changed, 19 insertions(+), 7 deletions(-)=0A=
>=0A=
> diff --git a/arch/arc/include/asm/dma-mapping.h b/arch/arc/include/asm/dm=
a-mapping.h=0A=
> index 2d28ba9..42eb526 100644=0A=
> --- a/arch/arc/include/asm/dma-mapping.h=0A=
> +++ b/arch/arc/include/asm/dma-mapping.h=0A=
> @@ -108,9 +108,13 @@ dma_map_sg(struct device *dev, struct scatterlist *s=
g,=0A=
>  	struct scatterlist *s;=0A=
>  	int i;=0A=
>  =0A=
> -	for_each_sg(sg, s, nents, i)=0A=
> -		s->dma_address =3D dma_map_page(dev, sg_page(s), s->offset,=0A=
> -					       s->length, dir);=0A=
> +	for_each_sg(sg, s, nents, i) {=0A=
> +		if (sg_has_page(s)) {=0A=
> +			_dma_cache_sync((unsigned long)sg_virt(s), s->length,=0A=
> +					dir);=0A=
> +		}=0A=
> +		s->dma_address =3D sg_phys(s);=0A=
> +	}=0A=
>  =0A=
>  	return nents;=0A=
>  }=0A=
> @@ -163,8 +167,12 @@ dma_sync_sg_for_cpu(struct device *dev, struct scatt=
erlist *sglist, int nelems,=0A=
>  	int i;=0A=
>  	struct scatterlist *sg;=0A=
>  =0A=
> -	for_each_sg(sglist, sg, nelems, i)=0A=
> -		_dma_cache_sync((unsigned int)sg_virt(sg), sg->length, dir);=0A=
> +	for_each_sg(sglist, sg, nelems, i) {=0A=
> +		if (sg_has_page(sg)) {=0A=
> +			_dma_cache_sync((unsigned int)sg_virt(sg), sg->length,=0A=
> +					dir);=0A=
> +		}=0A=
> +	}=0A=
>  }=0A=
>  =0A=
>  static inline void=0A=
> @@ -174,8 +182,12 @@ dma_sync_sg_for_device(struct device *dev, struct sc=
atterlist *sglist,=0A=
>  	int i;=0A=
>  	struct scatterlist *sg;=0A=
>  =0A=
> -	for_each_sg(sglist, sg, nelems, i)=0A=
> -		_dma_cache_sync((unsigned int)sg_virt(sg), sg->length, dir);=0A=
> +	for_each_sg(sglist, sg, nelems, i) {=0A=
> +		if (sg_has_page(sg)) {=0A=
> +			_dma_cache_sync((unsigned int)sg_virt(sg), sg->length,=0A=
> +				dir);=0A=
=0A=
For consistency, could u please fix the left alignment of @dir above - anot=
her tab=0A=
perhaps ?=0A=
=0A=
> +		}=0A=
> +	}=0A=
>  }=0A=
>  =0A=
>  static inline int dma_supported(struct device *dev, u64 dma_mask)=0A=
=0A=

  reply	other threads:[~2015-08-12 10:35 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-12  7:05 RFC: prepare for struct scatterlist entries without page backing Christoph Hellwig
2015-08-12  7:05 ` [PATCH 01/31] scatterlist: add sg_pfn and sg_has_page helpers Christoph Hellwig
2015-08-12  7:05 ` [PATCH 02/31] scatterlist: use sg_phys() Christoph Hellwig
2015-08-12  7:05 ` [PATCH 03/31] dma-debug: handle page-less SG entries Christoph Hellwig
2015-08-12  7:05 ` [PATCH 04/31] x86/pci-nommu: " Christoph Hellwig
2015-08-12  7:05 ` [PATCH 05/31] x86/pci-calgary: " Christoph Hellwig
2015-08-12  7:05 ` [PATCH 06/31] alpha/pci-noop: " Christoph Hellwig
2015-08-12  7:05 ` [PATCH 07/31] alpha/pci_iommu: " Christoph Hellwig
2015-08-12  7:05 ` [PATCH 08/31] c6x: " Christoph Hellwig
2015-08-12  7:05 ` [PATCH 09/31] ia64/pci_dma: " Christoph Hellwig
2015-08-12  7:05 ` [PATCH 10/31] powerpc/iommu: " Christoph Hellwig
2015-08-12  7:05 ` [PATCH 11/31] sparc/iommu: " Christoph Hellwig
2015-08-12  7:05 ` [PATCH 12/31] mn10300: " Christoph Hellwig
2015-08-12  7:05 ` [PATCH 13/31] sparc/ldc: " Christoph Hellwig
2015-08-12  7:05 ` [PATCH 14/31] sparc32/io-unit: " Christoph Hellwig
2015-08-12  7:05 ` [PATCH 15/31] sparc32/iommu: " Christoph Hellwig
2015-08-12  7:05 ` [PATCH 16/31] s390: " Christoph Hellwig
2015-08-12 11:51   ` Sebastian Ott
2015-08-12  7:05 ` [PATCH 17/31] ia64/sba_iommu: remove sba_sg_address Christoph Hellwig
2015-08-12  7:05 ` [PATCH 18/31] nios2: handle page-less SG entries Christoph Hellwig
2015-08-12  7:05 ` [PATCH 19/31] arc: " Christoph Hellwig
2015-08-12 10:28   ` Vineet Gupta [this message]
2015-08-12  7:05 ` [PATCH 20/31] avr32: " Christoph Hellwig
2015-08-12  9:36   ` Hans-Christian Egtvedt
2015-08-12  7:05 ` [PATCH 21/31] blackfin: " Christoph Hellwig
2015-08-12  7:05 ` [PATCH 22/31] metag: " Christoph Hellwig
2015-08-12  7:05 ` [PATCH 23/31] sh: " Christoph Hellwig
2015-08-12  7:05 ` [PATCH 24/31] xtensa: " Christoph Hellwig
2015-08-12  7:05 ` [PATCH 25/31] frv: " Christoph Hellwig
2015-08-12  7:05 ` [PATCH 26/31] openrisc: " Christoph Hellwig
2015-08-12  7:05 ` [PATCH 27/31] mips: " Christoph Hellwig
2015-08-12  7:05 ` [PATCH 28/31] powerpc: " Christoph Hellwig
2015-08-12  7:05 ` [PATCH 29/31] parisc: " Christoph Hellwig
2015-08-12 16:01   ` Linus Torvalds
2015-08-13 14:31     ` Christoph Hellwig
2015-08-14  3:30       ` Dan Williams
2015-08-14  3:59         ` James Bottomley
2015-08-14  4:11           ` David Miller
2015-08-14 16:17             ` Dan Williams
2015-08-12  7:05 ` [PATCH 30/31] intel-iommu: " Christoph Hellwig
2015-08-12  9:51   ` David Woodhouse
2015-08-12  7:05 ` [PATCH 31/31] dma-mapping-common: skip kmemleak checks for " Christoph Hellwig
2015-08-12 16:05   ` Linus Torvalds
2015-08-13 14:33     ` Christoph Hellwig
2015-08-12 16:26   ` Catalin Marinas
2015-08-12 12:42 ` RFC: prepare for struct scatterlist entries without page backing Boaz Harrosh
2015-08-12 23:37   ` Julian Calaby
2015-08-13 14:35     ` Christoph Hellwig
2015-08-13 23:40       ` Julian Calaby
2015-08-13 14:40   ` Christoph Hellwig
2015-08-13 15:42     ` Boaz Harrosh
2015-08-12 17:00 ` James Bottomley
2015-08-12 17:56   ` Grant Grundler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C2D7FE5348E1B147BCA15975FBA23075665B21F5@IN01WEMBXB.internal.synopsys.com \
    --to=vineet.gupta1@synopsys.com \
    --cc=alex.williamson@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=dan.j.williams@intel.com \
    --cc=dhowells@redhat.com \
    --cc=dwmw2@infradead.org \
    --cc=egtvedt@samfundet.no \
    --cc=grundler@parisc-linux.org \
    --cc=hch@lst.de \
    --cc=hskinnemoen@gmail.com \
    --cc=linux-alpha@vger.kernel.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-metag@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=linux-nvdimm@ml01.01.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux-xtensa@linux-xtensa.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=monstr@monstr.eu \
    --cc=realmz6@gmail.com \
    --cc=sparclinux@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).