From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FD4DCA9EA9 for ; Fri, 18 Oct 2019 21:54:43 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1A95520700 for ; Fri, 18 Oct 2019 21:54:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1A95520700 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 46w0Dw3ldWzDqp7 for ; Sat, 19 Oct 2019 08:54:40 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.210.66; helo=mail-ot1-f66.google.com; envelope-from=pku.leo@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=fail (p=none dis=none) header.from=nxp.com Received: from mail-ot1-f66.google.com (mail-ot1-f66.google.com [209.85.210.66]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 46w0Bv1gLbzDqjN for ; Sat, 19 Oct 2019 08:52:52 +1100 (AEDT) Received: by mail-ot1-f66.google.com with SMTP id z6so6230875otb.2 for ; Fri, 18 Oct 2019 14:52:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HvighmfITJLDYGeaiDUTpHYE/uCdU2psCtkCA9EvB0w=; b=oyW/A8G1QjjSr6Ev59ndPcOvzauFAQ+WO4yBpFxRGMWpKIDsShkzUgO9cfc9TACEgM 1V0WK3u2KBlG/x0sGpw/0K8nAdrofQhBovc0m5InjD6UCtW6KESmyiFaSF6WTNGs3saR QKyE3chffeJ3ajLLFUZKETEB0c0UhZOst5TH0vj2yEC0CbtTrucuf0mhKw72gA98ADv3 41wKPPFg59MQhkKHaZAWWGC4AVvbAXT4f7nV+MPXBtQ+xbk9rfDMo2oEolEsFcYa+B5e XWPUJNXapnVKJT+31BR9zYbigLqKvAN12Vv+7pUi+5Qh308AFV0DHnCou23zBv9xxWMC wNSg== X-Gm-Message-State: APjAAAWQf2fuV1GStdbZzGRsiNsuHUgEmIx9kaYzm94TLYBHB8US5nTp FZ0UrP/1tUvVb5Hxs9Tx8BXhR7Ob X-Google-Smtp-Source: APXvYqze1DUBk2BDbIEdXbcnIg0tzY6dRbbnVMSBvmTX0HfC8EJTsEXQuKcrHO/NOjVB9E91J9/gVA== X-Received: by 2002:a05:6830:f:: with SMTP id c15mr9659854otp.204.1571435569406; Fri, 18 Oct 2019 14:52:49 -0700 (PDT) Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com. [209.85.210.50]) by smtp.gmail.com with ESMTPSA id i13sm1866920otj.58.2019.10.18.14.52.48 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Oct 2019 14:52:48 -0700 (PDT) Received: by mail-ot1-f50.google.com with SMTP id 21so6181992otj.11 for ; Fri, 18 Oct 2019 14:52:48 -0700 (PDT) X-Received: by 2002:a9d:4d0d:: with SMTP id n13mr9769808otf.74.1571435568401; Fri, 18 Oct 2019 14:52:48 -0700 (PDT) MIME-Version: 1.0 References: <20191018125234.21825-1-linux@rasmusvillemoes.dk>

In-Reply-To: From: Li Yang Date: Fri, 18 Oct 2019 16:52:37 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/7] towards QE support on ARM To: Rasmus Villemoes Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Timur Tabi , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , "linux-serial@vger.kernel.org" , Jiri Slaby , "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , Qiang Zhao Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Oct 18, 2019 at 3:54 PM Rasmus Villemoes wrote: > > On 18/10/2019 22.16, Leo Li wrote: > > > >> > >> There have been several attempts in the past few years to allow building the > >> QUICC engine drivers for platforms other than PPC. This is (the beginning of) > >> yet another attempt. I hope I can get someone to pick up these relatively > >> trivial patches (I _think_ they shouldn't change functionality at all), and then > >> I'll continue slowly working towards removing the PPC32 dependency for > >> CONFIG_QUICC_ENGINE. > > > > Hi Rasmus, > > > > I don't fully understand the motivation of this work. As far as I know the QUICC ENGINE is only used on PowerPC based SoCs. > > Hm, you're not the Leo Li that participated in this thread > ? Oops, I totally forgot about this discussion which is just three years ago. :) The QE-HDLC on LS1021a is kind of a special case. > > > Can you give an example on how is it used on ARM system? > > LS1021A, for example, which is the one I'm aiming for getting fully > supported in mainline. > > > The forks at https://github.com/qoriq-open-source/linux.git have various > degrees of support (grep for commits saying stuff like "remove PPCisms" > - some versions can be found on > ). Our current kernel is > based on commits from the now-vanished 4.1 branch, and unfortunately at > least the 4.14 branch (LSDK-18.06-V4.14) trivially doesn't build on ARM, > despite the PPC32 dependency having been removed from CONFIG_QUICC_ENGINE. Can you try the 4.14 branch from a newer LSDK release? LS1021a should be supported platform on LSDK. If it is broken, something is wrong. > > >> > >> Tested on an MPC8309-derived board. > > > > MPC8309 is also PPC based. > > True, of course. This is just some first few steps, and I'm not claiming > that this is sufficient to make the QE drivers build on ARM yet. But I > have a customer with both mpc8309-based and ls1021a-based platforms, and > they want to run the same, as-close-to-mainline-as-possible, kernel on > both. So I will take a piecemeal approach, and try to make sure I don't > break the ppc boards in the process (just building and booting one board > is of course not sufficient, but better than nothing). Once I get to > actually build some of the QE drivers for ARM, I'll of course also test > them. Understood. Zhao Qiang also maintains some patches similar to your patchset and I think they are tested on ARM. But the review of these patches from last submission didn't finish. It looks like your patches are better divided but not really verified on ARM. Zhao Qiang's patches are tested but maybe need some final touch for cleaning up. I will let you guys decide what is the best approach to make this upstreamed. Regards, Leo