From: Daniel Baluta <daniel.baluta@gmail.com>
To: Yue Haibing <yuehaibing@huawei.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
linuxppc-dev@lists.ozlabs.org, Timur Tabi <timur@kernel.org>,
Xiubo Li <Xiubo.Lee@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>,
Nicolin Chen <nicoleotsuka@gmail.com>,
Mark Brown <broonie@kernel.org>,
Cosmin-Gabriel Samoila <gabrielcsmo@gmail.com>,
Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH -next] ASoC: fsl_micfil: Remove set but not used variable 'osr'
Date: Wed, 17 Apr 2019 18:25:11 +0300 [thread overview]
Message-ID: <CAEnQRZAug2kQoFTN6W47URBKwHcU5Zmmy=04smOtMomuzz6_TA@mail.gmail.com> (raw)
In-Reply-To: <20190417150915.37968-1-yuehaibing@huawei.com>
Hi Yue,
Looks good to me. Just one question for Cosmin:
On Wed, Apr 17, 2019 at 6:10 PM Yue Haibing <yuehaibing@huawei.com> wrote:
>
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> sound/soc/fsl/fsl_micfil.c: In function 'get_clk_div':
> sound/soc/fsl/fsl_micfil.c:154:6: warning: variable 'osr' set but not used [-Wunused-but-set-variable]
>
> It is never used since introduction in
> commit 47a70e6fc9a8 ("ASoC: Add MICFIL SoC Digital Audio Interface driver.")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> sound/soc/fsl/fsl_micfil.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/sound/soc/fsl/fsl_micfil.c b/sound/soc/fsl/fsl_micfil.c
> index 40c07e7..f7f2d29 100644
> --- a/sound/soc/fsl/fsl_micfil.c
> +++ b/sound/soc/fsl/fsl_micfil.c
> @@ -151,12 +151,9 @@ static inline int get_clk_div(struct fsl_micfil *micfil,
> {
> u32 ctrl2_reg;
> long mclk_rate;
> - int osr;
> int clk_div;
>
> regmap_read(micfil->regmap, REG_MICFIL_CTRL2, &ctrl2_reg);
I noticed now that we also read ctrl2_reg without using it. Is this as intended?
> - osr = 16 - ((ctrl2_reg & MICFIL_CTRL2_CICOSR_MASK)
> - >> MICFIL_CTRL2_CICOSR_SHIFT);
>
> mclk_rate = clk_get_rate(micfil->mclk);
>
> --
> 2.7.4
>
>
next prev parent reply other threads:[~2019-04-17 15:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 15:09 [PATCH -next] ASoC: fsl_micfil: Remove set but not used variable 'osr' Yue Haibing
2019-04-17 15:25 ` Daniel Baluta [this message]
2019-04-17 18:35 ` Nicolin Chen
2019-04-17 18:58 ` gabrielcsmo
2019-04-17 19:14 ` Nicolin Chen
2019-04-17 16:42 ` Applied "ASoC: fsl_micfil: Remove set but not used variable 'osr'" to the asoc tree Mark Brown
2019-05-02 2:18 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEnQRZAug2kQoFTN6W47URBKwHcU5Zmmy=04smOtMomuzz6_TA@mail.gmail.com' \
--to=daniel.baluta@gmail.com \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=gabrielcsmo@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=timur@kernel.org \
--cc=tiwai@suse.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).