From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Linuxppc-dev <linuxppc-dev@ozlabs.org>,
Randy Dunlap <rdunlap@infradead.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] powerpc/44x: Force PCI on for CURRITUCK
Date: Thu, 7 Feb 2019 09:18:02 +0100 [thread overview]
Message-ID: <CAMuHMdUzhG4_eXn3xrzrDKHJcvZmhe9QNCue0x+GuE3SauwOqg@mail.gmail.com> (raw)
In-Reply-To: <20190207024935.30456-1-mpe@ellerman.id.au>
Hi Michael,
On Thu, Feb 7, 2019 at 3:49 AM Michael Ellerman <mpe@ellerman.id.au> wrote:
> The recent rework of PCI kconfig symbols exposed an existing bug in
> the CURRITUCK kconfig logic.
>
> It selects PPC4xx_PCI_EXPRESS which depends on PCI, but PCI is user
> selectable and might be disabled, leading to a warning:
>
> WARNING: unmet direct dependencies detected for PPC4xx_PCI_EXPRESS
> Depends on [n]: PCI [=n] && 4xx [=y]
> Selected by [y]:
> - CURRITUCK [=y] && PPC_47x [=y]
>
> Prior to commit eb01d42a7778 ("PCI: consolidate PCI config entry in
> drivers/pci") PCI was enabled by default for currituck_defconfig so we
> didn't see the warning. The bad logic was still there, it just
> required someone disabling PCI in their .config to hit it.
>
> Fix it by forcing PCI on for CURRITUCK, which seems was always the
> expectation anyway.
>
> Fixes: eb01d42a7778 ("PCI: consolidate PCI config entry in drivers/pci")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> ---
> arch/powerpc/platforms/44x/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/powerpc/platforms/44x/Kconfig b/arch/powerpc/platforms/44x/Kconfig
> index 4a9a72d01c3c..35be81fd2dc2 100644
> --- a/arch/powerpc/platforms/44x/Kconfig
> +++ b/arch/powerpc/platforms/44x/Kconfig
> @@ -180,6 +180,7 @@ config CURRITUCK
> depends on PPC_47x
> select SWIOTLB
> select 476FPE
> + select FORCE_PCI
> select PPC4xx_PCI_EXPRESS
Would "select PPC4xx_PCI_EXPRESS if PCI" be a suitable alternative?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2019-02-07 8:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 2:49 [PATCH] powerpc/44x: Force PCI on for CURRITUCK Michael Ellerman
2019-02-07 5:37 ` Christoph Hellwig
2019-02-07 8:18 ` Geert Uytterhoeven [this message]
2019-02-08 11:46 ` Michael Ellerman
2019-02-22 9:47 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdUzhG4_eXn3xrzrDKHJcvZmhe9QNCue0x+GuE3SauwOqg@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=bhelgaas@google.com \
--cc=hch@lst.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).