linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Camelia Alexandra Groza <camelia.groza@nxp.com>
To: Scott Wood <oss@buserror.net>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	 "mark.rutland@arm.com" <mark.rutland@arm.com>,
	"benh@kernel.crashing.org" <benh@kernel.crashing.org>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
	"paulus@samba.org" <paulus@samba.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 2/3] powerpc/dts/fsl: t4240rdb: use the Cortina PHY driver compatible
Date: Tue, 8 Jan 2019 14:07:10 +0000	[thread overview]
Message-ID: <VI1PR04MB47996AC5BC20CC53F505880EF28A0@VI1PR04MB4799.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <6a64c160360bae80a4908d3ca7a887d0c0cb35c9.camel@buserror.net>

> -----Original Message-----
> From: Scott Wood <oss@buserror.net>
> Sent: Saturday, December 22, 2018 06:07
> To: Camelia Alexandra Groza <camelia.groza@nxp.com>;
> robh+dt@kernel.org; mark.rutland@arm.com; benh@kernel.crashing.org
> Cc: devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> paulus@samba.org; linuxppc-dev@lists.ozlabs.org
> Subject: Re: [PATCH 2/3] powerpc/dts/fsl: t4240rdb: use the Cortina PHY
> driver compatible
> 
> On Wed, 2018-07-18 at 14:46 +0300, Camelia Groza wrote:
> > The Cortina PHY requires the use of the dedicated Cortina PHY driver
> > instead of the generic one.
> >
> > Signed-off-by: Camelia Groza <camelia.groza@nxp.com>
> > ---
> >  arch/powerpc/boot/dts/fsl/t4240rdb.dts | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/powerpc/boot/dts/fsl/t4240rdb.dts
> > b/arch/powerpc/boot/dts/fsl/t4240rdb.dts
> > index 15eb0a3..a56a705 100644
> > --- a/arch/powerpc/boot/dts/fsl/t4240rdb.dts
> > +++ b/arch/powerpc/boot/dts/fsl/t4240rdb.dts
> > @@ -267,22 +267,22 @@
> >
> >  			mdio@fd000 {
> >  				xfiphy1: ethernet-phy@10 {
> > -					compatible = "ethernet-phy-
> ieee802.3-
> > c45";
> > +					compatible = "ethernet-phy-
> > id13e5.1002";
> >  					reg = <0x10>;
> >  				};
> >
> >  				xfiphy2: ethernet-phy@11 {
> > -					compatible = "ethernet-phy-
> ieee802.3-
> > c45";
> > +					compatible = "ethernet-phy-
> > id13e5.1002";
> >  					reg = <0x11>;
> >  				};
> >
> >  				xfiphy3: ethernet-phy@13 {
> > -					compatible = "ethernet-phy-
> ieee802.3-
> > c45";
> > +					compatible = "ethernet-phy-
> > id13e5.1002";
> >  					reg = <0x13>;
> >  				};
> >
> >  				xfiphy4: ethernet-phy@12 {
> > -					compatible = "ethernet-phy-
> ieee802.3-
> > c45";
> > +					compatible = "ethernet-phy-
> > id13e5.1002";
> >  					reg = <0x12>;
> >  				};
> >  			};
> 
> I get crashes on boot when using a dtb with this change:

Hi

Sorry for the late replay. I was on vacation. I'm looking into it.

Regards,
Camelia

  reply	other threads:[~2019-01-08 14:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-18 11:46 [PATCH 0/3] powerpc/dpaa: use the Cortina PHY driver Camelia Groza
2018-07-18 11:46 ` [PATCH 1/3] powerpc/configs/dpaa: enable " Camelia Groza
2018-07-18 11:46 ` [PATCH 2/3] powerpc/dts/fsl: t4240rdb: use the Cortina PHY driver compatible Camelia Groza
2018-08-08 22:47   ` [2/3] " Scott Wood
2018-12-22  4:06   ` [PATCH 2/3] " Scott Wood
2019-01-08 14:07     ` Camelia Alexandra Groza [this message]
2018-07-18 11:46 ` [PATCH 3/3] powerpc/dts/fsl: t2080rdb: " Camelia Groza

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR04MB47996AC5BC20CC53F505880EF28A0@VI1PR04MB4799.eurprd04.prod.outlook.com \
    --to=camelia.groza@nxp.com \
    --cc=benh@kernel.crashing.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mark.rutland@arm.com \
    --cc=oss@buserror.net \
    --cc=paulus@samba.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).