From: Wolfram Sang <wsa@kernel.org>
To: Sven Peter <sven@svenpeter.dev>
Cc: Alyssa Rosenzweig <alyssa@rosenzweig.io>,
Darren Stevens <darren@stevens-zone.net>,
Christian Zigotzky <chzigotzky@xenosoft.de>,
Hector Martin <marcan@marcan.st>,
linux-kernel@vger.kernel.org,
Arminder Singh <arminders208@outlook.com>,
Paul Mackerras <paulus@samba.org>,
linux-i2c@vger.kernel.org,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
linux-arm-kernel@lists.infradead.org, asahi@lists.linux.dev
Subject: Re: [PATCH v2] i2c/pasemi: PASemi I2C controller IRQ enablement
Date: Sun, 2 Oct 2022 13:28:41 +0200 [thread overview]
Message-ID: <Yzl16W6+poH8/8h4@shikoro> (raw)
In-Reply-To: <88f8c24a-70df-4b47-a3e8-033f6580d0d4@app.fastmail.com>
[-- Attachment #1: Type: text/plain, Size: 856 bytes --]
Hi,
some comments from me. Thanks for the patch and review!
> > This version of the patch has been tested on an M1 Ultra Mac Studio,
> > as well as an M1 MacBook Pro, and userspace launches successfully
> > while using the IRQ path for I2C transactions.
> >
> > Tested-by: Arminder Singh <arminders208@outlook.com>
>
> I think it's usually implied that you tested your own patches ;)
Yes, the tag is superfluous. The paragraph before is nice, though, to
learn which testing has been applied.
> > make sure to be more responsive this time around! Also wasn't sure whether
> > the v1 changelog belonged before or after the '---' so I put it after
> > to keep the commit changelog short and concise.
> > (This is just one patch, didn't think it needed a cover letter)
Both assumptions are correct.
Happy hacking,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-10-02 11:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-01 22:25 [PATCH v2] i2c/pasemi: PASemi I2C controller IRQ enablement Arminder Singh
2022-10-02 11:21 ` Sven Peter
2022-10-02 11:28 ` Wolfram Sang [this message]
2022-10-02 14:07 ` [PATCH v2] i2c-pasemi: " Arminder Singh
2022-10-02 15:02 ` Sven Peter
2022-10-04 1:27 ` Michael Ellerman
2022-10-05 19:04 ` Wolfram Sang
2022-10-02 15:28 ` [PATCH v2] i2c/pasemi: " Christian Zigotzky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yzl16W6+poH8/8h4@shikoro \
--to=wsa@kernel.org \
--cc=alyssa@rosenzweig.io \
--cc=arminders208@outlook.com \
--cc=asahi@lists.linux.dev \
--cc=chzigotzky@xenosoft.de \
--cc=darren@stevens-zone.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=marcan@marcan.st \
--cc=paulus@samba.org \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).