From: Michael Walle <michael@walle.cc>
To: Shawn Guo <shawnguo@kernel.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
lorenzo.pieralisi@arm.com, xiaowei.bao@nxp.com, roy.zang@nxp.com,
linux-pci@vger.kernel.org, Zhiqiang.Hou@nxp.com,
linux-kernel@vger.kernel.org, leoyang.li@nxp.com,
minghuan.Lian@nxp.com, robh+dt@kernel.org, mingkai.hu@nxp.com,
bhelgaas@google.com, linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 2/3] arm64: dts: ls1028a: Add PCIe controller DT nodes
Date: Mon, 24 Feb 2020 09:53:34 +0100 [thread overview]
Message-ID: <a3aeabddc82ca86e3dca9c26081a0077@walle.cc> (raw)
In-Reply-To: <20200224084307.GD27688@dragon>
Hi Shawn, all,
Am 2020-02-24 09:43, schrieb Shawn Guo:
> On Mon, Feb 24, 2020 at 09:11:05AM +0100, Michael Walle wrote:
>> Hi Xiaowei, Hi Shawn,
>>
>> > LS1028a implements 2 PCIe 3.0 controllers.
>>
>> Patch 1/3 and 3/3 are in Linus' tree but nobody seems to care about
>> this patch
>> anymore :(
>>
>> This doesn't work well with the IOMMU, because the iommu-map property
>> is
>> missing. The bootloader needs the &smmu phandle to fixup the entry.
>> See
>> below.
>>
>> Shawn, will you add this patch to your tree once its fixed,
>> considering it
>> just adds the device tree node for the LS1028A?
>
> The patch/thread is a bit aged. You may want to send an updated patch
> for discussion.
So should I just pick up the patch add my two fixes and send it again?
What about
the Signed-off-by tags? Leave them? Replace them? Add mine?
-michael
next prev parent reply other threads:[~2020-02-24 8:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-02 3:43 [PATCH v6 1/3] dt-bindings: pci: layerscape-pci: add compatible strings "fsl, ls1028a-pcie" Xiaowei Bao
2019-09-02 3:43 ` [PATCH v6 2/3] arm64: dts: ls1028a: Add PCIe controller DT nodes Xiaowei Bao
2020-02-24 8:11 ` Michael Walle
2020-02-24 8:43 ` Shawn Guo
2020-02-24 8:53 ` Michael Walle [this message]
2020-02-24 9:22 ` Z.q. Hou
2020-02-26 15:42 ` Michael Walle
2019-09-02 3:43 ` [PATCH v6 3/3] PCI: layerscape: Add LS1028a support Xiaowei Bao
2019-10-03 9:10 ` Shawn Guo
2019-10-08 7:11 ` Xiaowei Bao
2019-11-05 11:04 ` Andrew Murray
2019-11-05 12:32 ` Lorenzo Pieralisi
2019-11-06 3:35 ` Xiaowei Bao
2019-11-06 3:46 ` M.h. Lian
2019-11-06 15:01 ` Lorenzo Pieralisi
2019-11-05 11:05 ` [PATCH v6 1/3] dt-bindings: pci: layerscape-pci: add compatible strings "fsl,ls1028a-pcie" Andrew Murray
2019-11-06 16:09 ` Lorenzo Pieralisi
2019-11-07 3:07 ` Xiaowei Bao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3aeabddc82ca86e3dca9c26081a0077@walle.cc \
--to=michael@walle.cc \
--cc=Zhiqiang.Hou@nxp.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=minghuan.Lian@nxp.com \
--cc=mingkai.hu@nxp.com \
--cc=robh+dt@kernel.org \
--cc=roy.zang@nxp.com \
--cc=shawnguo@kernel.org \
--cc=xiaowei.bao@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).