From: Christophe Leroy <christophe.leroy@c-s.fr>
To: Michael Ellerman <mpe@ellerman.id.au>,
Joel Stanley <joel@jms.id.au>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc: vmlinux.lds: Drop Binutils 2.18 workarounds
Date: Tue, 26 Mar 2019 07:55:33 +0000 [thread overview]
Message-ID: <d340ae4b-a009-0ef3-9621-da3e0a7684f5@c-s.fr> (raw)
In-Reply-To: <874l7qpi7l.fsf@concordia.ellerman.id.au>
On 03/26/2019 12:55 AM, Michael Ellerman wrote:
> Joel Stanley <joel@jms.id.au> writes:
>> Segher added some workarounds for GCC 4.2 and bintuils 2.18. We now set
>> 4.6 and 2.20 as the minimum, so they can be dropped.
>>
>> This is mostly a revert of c69cccc95fe4 ("powerpc: Fix build bug with
>> binutils < 2.18 and GCC < 4.2").
>>
>> Signed-off-by: Joel Stanley <joel@jms.id.au>
>> ---
>> arch/powerpc/kernel/vmlinux.lds.S | 35 ++++---------------------------
>> 1 file changed, 4 insertions(+), 31 deletions(-)
>
> Seems this breaks some toolchains, at least the one from kernel.org:
>
> /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld: .tmp_vmlinux1: Not enough room for program headers, try linking with -N
> /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld: final link failed: Bad value
> make[1]: *** [/kisskb/src/Makefile:1024: vmlinux] Error 1
>
> http://kisskb.ellerman.id.au/kisskb/buildresult/13743374/
>
> Not sure why.
>
> That's binutils 2.30.
>
> cheers
>
Without the patch on PPC32:
Program Header:
LOAD off 0x00010000 vaddr 0xc0000000 paddr 0x00000000 align 2**16
filesz 0x003c2ce4 memsz 0x003e1a08 flags rwx
NOTE off 0x0038dca8 vaddr 0xc037dca8 paddr 0x0037dca8 align 2**2
filesz 0x0000003c memsz 0x0000003c flags ---
NOTE off 0x0038dce4 vaddr 0xc037dce4 paddr 0x0037dce4 align 2**0
filesz 0x0000000c memsz 0x0000000c flags ---
With the patch:
Program Header:
LOAD off 0x00010000 vaddr 0xc0000000 paddr 0x00000000 align 2**16
filesz 0x003c2ce4 memsz 0x003e1a08 flags rwx
NOTE off 0x0038dca8 vaddr 0xc037dca8 paddr 0x0037dca8 align 2**2
filesz 0x0000003c memsz 0x0000003c flags r--
STACK off 0x00000000 vaddr 0x00000000 paddr 0x00000000 align 2**4
filesz 0x00000000 memsz 0x00000000 flags rwx
Christophe
next prev parent reply other threads:[~2019-03-26 7:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 0:32 [PATCH] powerpc: vmlinux.lds: Drop Binutils 2.18 workarounds Joel Stanley
2019-03-21 23:34 ` Segher Boessenkool
2019-03-22 0:22 ` Michael Ellerman
2019-03-26 0:55 ` Michael Ellerman
2019-03-26 7:55 ` Christophe Leroy [this message]
2019-03-26 18:19 ` Segher Boessenkool
2019-03-26 19:28 ` Christophe Leroy
2019-03-26 20:12 ` Segher Boessenkool
2019-03-26 22:29 ` Segher Boessenkool
2019-03-26 22:59 ` Segher Boessenkool
2019-03-27 6:40 ` Christophe Leroy
2019-03-27 12:47 ` Segher Boessenkool
2019-03-27 18:21 ` Segher Boessenkool
2019-03-28 6:19 ` Christophe Leroy
2019-03-28 15:11 ` Segher Boessenkool
2019-03-27 8:56 ` Christophe Leroy
2019-03-27 9:09 ` Christophe Leroy
2019-03-26 8:08 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d340ae4b-a009-0ef3-9621-da3e0a7684f5@c-s.fr \
--to=christophe.leroy@c-s.fr \
--cc=joel@jms.id.au \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).