From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9DB4C433DF for ; Fri, 5 Jun 2020 14:21:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BFB942074B for ; Fri, 5 Jun 2020 14:21:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591366881; bh=lQhl9VjPpQqPHD07ccAprin/eMBfjjoE6H6u38WkXG4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=vEdUL1yrfT3s753/6TnlMw9nOI9Op04si9fDP/B5qjp4UM5AFP/dSnZ8oK5X4UrZ3 V7mqY9IYvF8TEHS5jqe+yEiZ/ibRiN/VXLraLfyU1PfLgyo4oyZJ7FUX9PQ7WNlINL bA0NZjzqShUEpj6f0zCAaaV6eTGT/4cpZVlnMRaU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728952AbgFEOVV (ORCPT ); Fri, 5 Jun 2020 10:21:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:51462 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728935AbgFEOUP (ORCPT ); Fri, 5 Jun 2020 10:20:15 -0400 Received: from linux-8ccs.fritz.box (p57a23121.dip0.t-ipconnect.de [87.162.49.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F392A208A9; Fri, 5 Jun 2020 14:20:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591366814; bh=lQhl9VjPpQqPHD07ccAprin/eMBfjjoE6H6u38WkXG4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=B1bANglDGNNAxIm0D9lBYOGI2a3GiqmxrciDb1YXY62MpCrwmyvnZ0UUHn99RQxRC funpZ/+Xjg/7isnDOsQkO1gbdu7SXGgfi1ab41YnAwhfM8JG4vMPvUhHKmDIJfZCaw MR5vvR3PNQleUjcEPg3nh34HLCQ+Y0eA0bL7IeMw= Date: Fri, 5 Jun 2020 16:20:10 +0200 From: Jessica Yu To: Guenter Roeck Cc: Josh Poimboeuf , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Zijlstra , Joe Lawrence , Miroslav Benes , Linus Torvalds Subject: Re: [PATCH v4 11/11] module: Make module_enable_ro() static again Message-ID: <20200605142009.GA5150@linux-8ccs.fritz.box> References: <20200605132450.GA257550@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200605132450.GA257550@roeck-us.net> X-OS: Linux linux-8ccs 4.12.14-lp150.12.61-default x86_64 User-Agent: Mutt/1.10.1 (2018-07-13) Sender: live-patching-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: live-patching@vger.kernel.org +++ Guenter Roeck [05/06/20 06:24 -0700]: >On Wed, Apr 29, 2020 at 10:24:53AM -0500, Josh Poimboeuf wrote: >> Now that module_enable_ro() has no more external users, make it static >> again. >> >> Suggested-by: Jessica Yu >> Signed-off-by: Josh Poimboeuf >> Acked-by: Miroslav Benes > >Apparently this patch made it into the upstream kernel on its own, >not caring about its dependencies. Results are impressive. > >Build results: > total: 155 pass: 101 fail: 54 >Qemu test results: > total: 431 pass: 197 fail: 234 > >That means bisects will be all but impossible until this is fixed. >Was that really necessary ? Sigh, I am really sorry about this. We made a mistake in handling inter-tree dependencies between livepatching and modules-next, unfortunately :-( Merging the modules-next pull request next should resolve the module_enable_ro() not defined for !ARCH_HAS_STRICT_MODULE_RWX build issue. The failure was hidden in linux-next since both trees were always merged together. Again, it doesn't excuse us from build testing our separate trees more rigorously.