From: Josh Poimboeuf <jpoimboe@redhat.com>
To: "Wangshaobo (bobo)" <bobo.shaobowang@huawei.com>
Cc: huawei.libin@huawei.com, xiexiuqi@huawei.com,
cj.chengjian@huawei.com, mingo@redhat.com, x86@kernel.org,
linux-kernel@vger.kernel.org, live-patching@vger.kernel.org,
mbenes@suse.cz, devel@etsukata.com, viro@zeniv.linux.org.uk,
esyr@redhat.com
Subject: Re: Question: livepatch failed for new fork() task stack unreliable
Date: Tue, 30 Jun 2020 16:36:39 -0500 [thread overview]
Message-ID: <20200630213639.kijctnz4y3zjbkhx@treble> (raw)
In-Reply-To: <e914bcd6-009c-0a89-bc59-b9a87a9c552d@huawei.com>
On Tue, Jun 30, 2020 at 09:04:12PM +0800, Wangshaobo (bobo) wrote:
>
> 在 2020/6/5 9:51, Josh Poimboeuf 写道:
> > On Fri, Jun 05, 2020 at 09:26:42AM +0800, Wangshaobo (bobo) wrote:
> > > > > So, I want to ask is there any side effects if i modify like this ? this
> > > > > modification is based on
> > > > >
> > > > > your fix. It looks like ok with proper test.
> > > > >
> > > > > diff --git a/arch/x86/kernel/unwind_orc.c b/arch/x86/kernel/unwind_orc.c
> > > > > index e9cc182aa97e..ecce5051e8fd 100644
> > > > > --- a/arch/x86/kernel/unwind_orc.c
> > > > > +++ b/arch/x86/kernel/unwind_orc.c
> > > > > @@ -620,6 +620,7 @@ void __unwind_start(struct unwind_state *state, struct
> > > > > task_struct *task,
> > > > > state->sp = task->thread.sp;
> > > > > state->bp = READ_ONCE_NOCHECK(frame->bp);
> > > > > state->ip = READ_ONCE_NOCHECK(frame->ret_addr);
> > > > > + state->signal = ((void *)state->ip == ret_from_fork);
> > > > > }
> > > > >
> > > > > diff --git a/arch/x86/kernel/unwind_orc.c b/arch/x86/kernel/unwind_orc.c
> > > > > index 7f969b2d240f..d7396431261a 100644
> > > > > --- a/arch/x86/kernel/unwind_orc.c
> > > > > +++ b/arch/x86/kernel/unwind_orc.c
> > > > > @@ -540,7 +540,7 @@ bool unwind_next_frame(struct unwind_state *state)
> > > > > state->sp = sp;
> > > > > state->regs = NULL;
> > > > > state->prev_regs = NULL;
> > > > > - state->signal = ((void *)state->ip == ret_from_fork);
> > > > > + state->signal = false;
> > > > > break;
> > > > Yes that's correct.
> > > Hi, josh
> > >
> > > Could i ask when are you free to send the patch, all the tests are passed
> > > by.
> > I want to run some regression tests, so it will probably be next week.
Sorry, I was away for a bit and I didn't get a chance to send the patch.
I should hopefully have it ready soon.
--
Josh
prev parent reply other threads:[~2020-06-30 21:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 10:10 Question: livepatch failed for new fork() task stack unreliable Wang ShaoBo
2020-05-29 17:44 ` Josh Poimboeuf
[not found] ` <a9ed9157-f3cf-7d2c-7a8e-56150a2a114e@huawei.com>
2020-06-01 18:05 ` Josh Poimboeuf
2020-06-02 1:22 ` Wangshaobo (bobo)
2020-06-02 13:14 ` Josh Poimboeuf
2020-06-03 14:06 ` Wangshaobo (bobo)
2020-06-03 15:33 ` Josh Poimboeuf
2020-06-04 1:24 ` Wangshaobo (bobo)
2020-06-04 2:40 ` Josh Poimboeuf
2020-06-05 1:26 ` Wangshaobo (bobo)
2020-06-05 1:51 ` Josh Poimboeuf
2020-06-30 13:04 ` Wangshaobo (bobo)
2020-06-30 21:36 ` Josh Poimboeuf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200630213639.kijctnz4y3zjbkhx@treble \
--to=jpoimboe@redhat.com \
--cc=bobo.shaobowang@huawei.com \
--cc=cj.chengjian@huawei.com \
--cc=devel@etsukata.com \
--cc=esyr@redhat.com \
--cc=huawei.libin@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=mingo@redhat.com \
--cc=viro@zeniv.linux.org.uk \
--cc=x86@kernel.org \
--cc=xiexiuqi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).