From: Steven Rostedt <rostedt@goodmis.org>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: live-patching@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Petr Mladek <pmladek@suse.com>,
Joe Lawrence <joe.lawrence@redhat.com>,
Jiri Kosina <jikos@kernel.org>, Miroslav Benes <mbenes@suse.cz>,
kernel-janitors <kernel-janitors@vger.kernel.org>
Subject: Re: Reference to non-existing DYNAMIC_FTRACE_WITH_ARGS
Date: Fri, 6 Aug 2021 09:22:50 -0400 [thread overview]
Message-ID: <20210806092250.1bb21ac6@oasis.local.home> (raw)
In-Reply-To: <CAKXUXMwT2zS9fgyQHKUUiqo8ynZBdx2UEUu1WnV_q0OCmknqhw@mail.gmail.com>
On Fri, 6 Aug 2021 12:18:36 +0200
Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
> Hi Steven,
Hi Lukas, thanks for the report.
> Did you intend to depend on the existing "HAVE_DYNAMIC_FTRACE_WITH_ARGS" here?
>
> Or did you intend to add a new config DYNAMIC_FTRACE_WITH_ARGS
> analogously to DYNAMIC_FTRACE_WITH_REGS as defined in
> ./kernel/trace/Kconfig (see below)?
>
> config DYNAMIC_FTRACE_WITH_REGS
> def_bool y
> depends on DYNAMIC_FTRACE
> depends on HAVE_DYNAMIC_FTRACE_WITH_REGS
>
> I am happy to provide a patch, once I understand what was intended here.
>
Yeah, that looks to be the missing part. The
HAVE_DYNAMIC_FTRACE_WITH_ARGS is just showing support, but knowing it
is enabled would require DYNAMIC_FTRACE being set (which is user
enabled).
Feel free to send a patch, and mark it for stable.
-- Steve
prev parent reply other threads:[~2021-08-06 13:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 10:18 Reference to non-existing DYNAMIC_FTRACE_WITH_ARGS Lukas Bulwahn
2021-08-06 13:22 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210806092250.1bb21ac6@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=mbenes@suse.cz \
--cc=mingo@redhat.com \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).