From: Aaron Tomlin <atomlin@atomlin.com>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: "20220209170358.3266629-1-atomlin@redhat.com"
<20220209170358.3266629-1-atomlin@redhat.com>,
"mcgrof@kernel.org" <mcgrof@kernel.org>,
Aaron Tomlin <atomlin@redhat.com>, "cl@linux.com" <cl@linux.com>,
"pmladek@suse.com" <pmladek@suse.com>,
"mbenes@suse.cz" <mbenes@suse.cz>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"jeyu@kernel.org" <jeyu@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-modules@vger.kernel.org" <linux-modules@vger.kernel.org>,
"live-patching@vger.kernel.org" <live-patching@vger.kernel.org>,
"ghalat@redhat.com" <ghalat@redhat.com>,
"allen.lkml@gmail.com" <allen.lkml@gmail.com>,
"void@manifault.com" <void@manifault.com>,
"joe@perches.com" <joe@perches.com>,
"msuchanek@suse.de" <msuchanek@suse.de>,
"oleksandr@natalenko.name" <oleksandr@natalenko.name>
Subject: Re: [PATCH v5 08/13] module: Move kmemleak support to a separate file
Date: Fri, 11 Feb 2022 15:42:04 +0000 [thread overview]
Message-ID: <20220211154204.2x66sauy3o7albbe@ava.usersys.com> (raw)
In-Reply-To: <2bee9eb2-d59f-a5cd-d89a-b818d94b74af@csgroup.eu>
On Thu 2022-02-10 13:07 +0000, Christophe Leroy wrote:
> CHECK: Alignment should match open parenthesis
> #48: FILE: kernel/module/debug_kmemleak.c:13:
> +void kmemleak_load_module(const struct module *mod,
> + const struct load_info *info)
Ok.
> > +static inline void __maybe_unused kmemleak_load_module(const struct module *mod,
> > + const struct load_info *info) { }
>
> Remove __maybe_unused, not needed for a 'static inline' in the .h
Agreed.
Thanks for your feedback Christophe.
Kind regards,
--
Aaron Tomlin
next prev parent reply other threads:[~2022-02-11 15:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 17:08 [PATCH v5 07/13] module: Move extra signature support out of core code Aaron Tomlin
2022-02-09 17:08 ` [PATCH v5 08/13] module: Move kmemleak support to a separate file Aaron Tomlin
2022-02-10 13:07 ` Christophe Leroy
2022-02-11 15:42 ` Aaron Tomlin [this message]
2022-02-09 17:08 ` [PATCH v5 09/13] module: Move kallsyms support into " Aaron Tomlin
2022-02-10 13:43 ` Christophe Leroy
2022-02-11 19:55 ` Aaron Tomlin
2022-02-09 17:08 ` [PATCH v5 10/13] module: Move procfs " Aaron Tomlin
2022-02-10 13:46 ` Christophe Leroy
2022-02-09 20:48 ` [PATCH v5 07/13] module: Move extra signature support out of core code Michal Suchánek
2022-02-10 9:59 ` Aaron Tomlin
2022-02-10 13:01 ` Christophe Leroy
2022-02-11 13:51 ` Aaron Tomlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220211154204.2x66sauy3o7albbe@ava.usersys.com \
--to=atomlin@atomlin.com \
--cc=20220209170358.3266629-1-atomlin@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=allen.lkml@gmail.com \
--cc=atomlin@redhat.com \
--cc=christophe.leroy@csgroup.eu \
--cc=cl@linux.com \
--cc=ghalat@redhat.com \
--cc=jeyu@kernel.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=mcgrof@kernel.org \
--cc=msuchanek@suse.de \
--cc=oleksandr@natalenko.name \
--cc=pmladek@suse.com \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).