From: Nicolai Stange <nstange@suse.de>
To: Petr Mladek <pmladek@suse.com>
Cc: Jiri Kosina <jikos@kernel.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Miroslav Benes <mbenes@suse.cz>,
Joe Lawrence <joe.lawrence@redhat.com>,
Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>,
Nicolai Stange <nstange@suse.de>,
live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC 2/5] livepatch: Basic API to track system state changes
Date: Mon, 24 Jun 2019 11:32:19 +0200 [thread overview]
Message-ID: <87k1db49cs.fsf@suse.de> (raw)
In-Reply-To: <20190611135627.15556-3-pmladek@suse.com> (Petr Mladek's message of "Tue, 11 Jun 2019 15:56:24 +0200")
Petr Mladek <pmladek@suse.com> writes:
> ---
> include/linux/livepatch.h | 15 +++++++++
> kernel/livepatch/Makefile | 2 +-
> kernel/livepatch/state.c | 83 +++++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 99 insertions(+), 1 deletion(-)
> create mode 100644 kernel/livepatch/state.c
>
> diff --git a/include/linux/livepatch.h b/include/linux/livepatch.h
> index eeba421cc671..591abdee30d7 100644
> --- a/include/linux/livepatch.h
> +++ b/include/linux/livepatch.h
> @@ -132,10 +132,21 @@ struct klp_object {
> bool patched;
> };
>
> +/**
> + * struct klp_state - state of the system modified by the livepatch
> + * @id: system state identifier (non zero)
> + * @data: custom data
> + */
> +struct klp_state {
> + int id;
Can we make this an unsigned long please? It would be consistent with
shadow variable ids and would give more room for encoding bugzilla or
CVE numbers or so.
Nicolai
> + void *data;
> +};
> +
next prev parent reply other threads:[~2019-06-24 9:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190611135627.15556-1-pmladek@suse.com>
2019-06-21 13:19 ` [RFC 0/5] livepatch: new API to track system state changes Joe Lawrence
[not found] ` <20190611135627.15556-3-pmladek@suse.com>
2019-06-21 13:43 ` [RFC 2/5] livepatch: Basic " Joe Lawrence
2019-06-24 9:32 ` Nicolai Stange [this message]
[not found] ` <20190611135627.15556-5-pmladek@suse.com>
2019-06-21 14:15 ` [RFC 4/5] livepatch: Documentation of the new API for tracking " Joe Lawrence
[not found] ` <20190611135627.15556-6-pmladek@suse.com>
2019-06-21 11:54 ` [RFC 5/5] livepatch: Selftests of the " Miroslav Benes
2019-06-21 14:19 ` Joe Lawrence
2019-06-24 9:27 ` [RFC 0/5] livepatch: new API to track " Nicolai Stange
[not found] ` <20190611135627.15556-4-pmladek@suse.com>
2019-06-21 11:27 ` [RFC 3/5] livepatch: Allow to distinguish different version of " Miroslav Benes
2019-06-21 14:09 ` Joe Lawrence
2019-06-21 15:00 ` Joe Lawrence
2019-06-24 10:26 ` Nicolai Stange
2019-07-18 11:38 ` Petr Mladek
2019-07-18 9:08 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1db49cs.fsf@suse.de \
--to=nstange@suse.de \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).