From: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
To: Joe Lawrence <joe.lawrence@redhat.com>
Cc: live-patching@vger.kernel.org, linux-kselftest@vger.kernel.org,
Miroslav Benes <mbenes@suse.cz>, Petr Mladek <pmladek@suse.com>
Subject: Re: [PATCH v2 0/4] selftests/livepatch: small script cleanups
Date: Tue, 16 Jun 2020 13:59:19 +0530 [thread overview]
Message-ID: <9502b7e6-bf62-678c-aa10-6be01d769c6f@linux.vnet.ibm.com> (raw)
In-Reply-To: <20200615172756.12912-1-joe.lawrence@redhat.com>
On 6/15/20 10:57 PM, Joe Lawrence wrote:
> This is a small collection of tweaks for the shellscript side of the
> livepatch tests. If anyone else has a small cleanup (or even just a
> suggestion for a low-hanging change) and would like to tack it onto the
> set, let me know.
>
> based-on: livepatching.git, for-5.9/selftests-cleanup
> merge-thru: livepatching.git
>
> v2:
> - use consistent start_test messages from the original echoes [mbenes]
> - move start_test invocations to just after their descriptions [mbenes]
> - clean up $SAVED_DMSG on trap EXIT [pmladek]
> - grep longer kernel taint line, avoid word-matching [mbenes, pmladek]
> - add "===== TEST: $test =====" delimiter patch [pmladek]
>
> Joe Lawrence (4):
> selftests/livepatch: Don't clear dmesg when running tests
> selftests/livepatch: use $(dmesg --notime) instead of manually
> filtering
> selftests/livepatch: refine dmesg 'taints' in dmesg comparison
> selftests/livepatch: add test delimiter to dmesg
>
> tools/testing/selftests/livepatch/README | 16 +++---
> .../testing/selftests/livepatch/functions.sh | 32 ++++++++++-
> .../selftests/livepatch/test-callbacks.sh | 55 ++++---------------
> .../selftests/livepatch/test-ftrace.sh | 4 +-
> .../selftests/livepatch/test-livepatch.sh | 12 +---
> .../selftests/livepatch/test-shadow-vars.sh | 4 +-
> .../testing/selftests/livepatch/test-state.sh | 21 +++----
> 7 files changed, 63 insertions(+), 81 deletions(-)
>
For the series:
Reviewed-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
--
Kamalesh
next prev parent reply other threads:[~2020-06-16 8:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 17:27 [PATCH v2 0/4] selftests/livepatch: small script cleanups Joe Lawrence
2020-06-15 17:27 ` [PATCH v2 1/4] selftests/livepatch: Don't clear dmesg when running tests Joe Lawrence
2020-06-15 17:27 ` [PATCH v2 2/4] selftests/livepatch: use $(dmesg --notime) instead of manually filtering Joe Lawrence
2020-06-17 9:23 ` Petr Mladek
2020-06-17 11:22 ` Joe Lawrence
2020-06-15 17:27 ` [PATCH v2 3/4] selftests/livepatch: refine dmesg 'taints' in dmesg comparison Joe Lawrence
2020-06-15 17:27 ` [PATCH v2 4/4] selftests/livepatch: add test delimiter to dmesg Joe Lawrence
2020-06-16 8:29 ` Kamalesh Babulal [this message]
2020-06-16 11:05 ` [PATCH v2 0/4] selftests/livepatch: small script cleanups Miroslav Benes
2020-06-16 14:43 ` Petr Mladek
2020-06-16 15:16 ` Yannick Cote
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9502b7e6-bf62-678c-aa10-6be01d769c6f@linux.vnet.ibm.com \
--to=kamalesh@linux.vnet.ibm.com \
--cc=joe.lawrence@redhat.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).